always use a vptr (possibly with an empty type) in object representations #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwblaikie
force-pushed
the
vptr_always
branch
from
1439655
to
e25d89d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks a lot of tests and lowering (with a pre-existing crash, probably just due to the lack of lowering of the initializer (or lowering it in check into an Error builtin, specifically), that only happens currently in dynamic classes, but by putting a vptr (even a zero-length one) in every class means they all hit that crash) so the presubmit checks aren't clear, but that's not really the fault of this patch.