Convert array bounds to IntLiteral.
#4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #4525. Review only the last commit here. |
sized integer types. In preparation for changing integer literals to be of `IntLiteral` type. Conversions from the integer literal type are only permitted when the value fits within the destination type. For now, if conversion cannot be checked because the source value is a symbolic constant, produce a symbolic constant representing the conversion rather than rejecting it.
zygoloid
force-pushed
the
toolchain-convert-array-bounds
branch
from
3964c95
to
3a61b81
Compare
Don't hold a Function& after it may have been invalidated by importing.
zygoloid
force-pushed
the
toolchain-convert-array-bounds
branch
from
3a61b81
to
eb99749
Compare
jonmeow
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Should we be trying to reduce the noise in these imports? This seems to be 700 lines per test file using i32 (I'm guessing 10-20 KB?), repeated per-test for split files (e.g., see the delta for array.carbon). Also, presumably will increase churn when an interface is added. I think there's some benefit to the full representation, but this is big enough that I'm wondering if we should be more concerned about long-term repo size issues.
The basics of this PR seem okay, but what's the filesize of the 80K line delta?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of leaving array bounds as whatever integer type they arrive as, convert them to the
IntLiteraltype as part of forming anArrayType. This ensures that array types canonicalize properly even when the bounds are specified with different types.Create an empty generic definition for a generic builtin function to avoid this causing "use of undefined generic function" errors.