Skip to content

Conversation

@jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Nov 6, 2025

  • Change the look-and-feel of the carbon compilation command set to use
    compile, link, and build.
  • Build library-to-file discovery for Core, but support it in a general
    manner.

Drafted in Docs

@jonmeow jonmeow added proposal A proposal proposal draft Proposal in draft, not ready for review labels Nov 6, 2025
@jonmeow jonmeow marked this pull request as ready for review November 6, 2025 18:45
@jonmeow jonmeow requested a review from a team as a code owner November 6, 2025 18:45
@jonmeow jonmeow requested review from zygoloid and removed request for a team November 6, 2025 18:45
@github-actions github-actions bot added proposal rfc Proposal with request-for-comment sent out and removed proposal draft Proposal in draft, not ready for review labels Nov 6, 2025
Copy link
Contributor Author

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, pulled out a lot of the Bazel mentions out separately and trying to avoid making design choices for it here. (trying to just use it for illustrative purposes)

@jonmeow jonmeow requested a review from zygoloid December 1, 2025 18:27
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly LG, but there are a few areas where I think we'd benefit from being clearer about what is proposed versus what is being left for us to work out as part of the implementation.

Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

I'd like @chandlerc to have a look with his painter hat on, specifically to check the defaults match his expectations (default.carbon as the default library in a package, and a default output binary named program), but I'm happy.


It will be typical to link multiple object files into a single output file. The
output file flag will be optional, defaulting to `program`, possibly with a
target-specific extension; for example, `platform.exe` for Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say program.exe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposal rfc Proposal with request-for-comment sent out proposal A proposal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants