-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CLI and separate compilation #6333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Co-authored-by: Richard Smith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion, pulled out a lot of the Bazel mentions out separately and trying to avoid making design choices for it here. (trying to just use it for illustrative purposes)
zygoloid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly LG, but there are a few areas where I think we'd benefit from being clearer about what is proposed versus what is being left for us to work out as part of the implementation.
Co-authored-by: Richard Smith <[email protected]>
zygoloid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
I'd like @chandlerc to have a look with his painter hat on, specifically to check the defaults match his expectations (default.carbon as the default library in a package, and a default output binary named program), but I'm happy.
proposals/p6333.md
Outdated
|
|
||
| It will be typical to link multiple object files into a single output file. The | ||
| output file flag will be optional, defaulting to `program`, possibly with a | ||
| target-specific extension; for example, `platform.exe` for Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say program.exe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. :)
carboncompilation command set to usecompile,link, andbuild.Core, but support it in a generalmanner.
Drafted in Docs