Reduce the minimum benchmark batch size #6436
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even with `--benchmark_dry_run`, the benchmarks that use _batching_ still do one batch at a minimum as that's inherent to how batching works in the benchmark framework. This means that the minimum batch size can (and in practice does) trigger timeouts by forcing 1k iterations in the test run that is just trying to ensure the benchmark doesn't _crash_ in some way. Reduce the minimum size to 128 instead of 1k for this benchmark which should put it (much) further from any timeout limit. It also still seems perfectly effective for getting good benchmark data -- I think the original value was set _much_ too aggressively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with
--benchmark_dry_run, the benchmarks that use batching still do one batch at a minimum as that's inherent to how batching works in the benchmark framework.This means that the minimum batch size can (and in practice does) trigger timeouts by forcing 1k iterations in the test run that is just trying to ensure the benchmark doesn't crash in some way.
Reduce the minimum size to 128 instead of 1k for this benchmark which should put it (much) further from any timeout limit. It also still seems perfectly effective for getting good benchmark data -- I think the original value was set much too aggressively.