Skip to content

Conversation

@vlasin
Copy link

@vlasin vlasin commented Oct 31, 2025

👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

  1. Please complete a Checklist
  2. Fill in all sections of the template
  3. Click "Create pull request"

Checklist

<-- Please fill the boxes with [x] before submitting a pull request -->

Builder Tool addition

<-- Provide information for every bullet in the list below. The tags you select must match the tags in your changes to the builder-tools.js -->

  • Title: Project name
  • Description: Describe your project
  • Website: <link_to_project>
  • Getstarted: <link_to_getstarted_page>
  • Tags:
    • chainindex
    • cli
    • golang
    • IDE
    • java
    • javascript
    • marlowe
    • net
    • nft
    • operatortool
    • oracle
    • plutus
    • python
    • rust
    • purescript
    • websocket
    • http
    • json
    • haskell
    • typescript
    • wallet
    • serialization
    • sdk
    • redis
    • sql
    • lowlevel
    • testing
    • hosted

@rphair
Copy link
Collaborator

rphair commented Nov 5, 2025

correlating with #1670 (I hope to review the two of them soon)

@rphair rphair changed the title Add Smart Wallet API Add Smart Wallet API to Builder Tools Nov 5, 2025
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there was something mixed up because the as a website linked URL https://wallet-api.zkfold.io just gives back {"errorCode":"NOT_FOUND","message":"Not Found"}

(People will get there if they click the Builder Tool Banner)

@vlasin
Copy link
Author

vlasin commented Nov 5, 2025

I assume there was something mixed up because the as a website linked URL https://wallet-api.zkfold.io just gives back {"errorCode":"NOT_FOUND","message":"Not Found"}

(People will get there if they click the Builder Tool Banner)

I originally assumed that I should provide the base path for the APIs. Now, the link points to the Swagger docs.

@vlasin
Copy link
Author

vlasin commented Nov 5, 2025

Launch announcement on X regarding this product:
https://x.com/zkFold/status/1986031607434629213

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlasin this is the thread where most discussion is taking place so I'll provide feedback here for now, since I think both your concurrent submissions share some considerations:

  • Using the same thumbnail issue for this and for #1670 make this submission look like a duplicate unless looking closely. Can you update one or more of these thumbnail images to differentiate the wallet image from this API image?
  • This is an interesting premise that I would support in the community but would be interested in how you've documented any security concerns and especially if the API and/or wallet have been audited. I haven't looked at all the linked documentation pages but can you please share a link about audit / security assurances if available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants