-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Smart Wallet API to Builder Tools #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
|
correlating with #1670 (I hope to review the two of them soon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume there was something mixed up because the as a website linked URL https://wallet-api.zkfold.io just gives back {"errorCode":"NOT_FOUND","message":"Not Found"}
(People will get there if they click the Builder Tool Banner)
I originally assumed that I should provide the base path for the APIs. Now, the link points to the Swagger docs. |
|
Launch announcement on X regarding this product: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vlasin this is the thread where most discussion is taking place so I'll provide feedback here for now, since I think both your concurrent submissions share some considerations:
- Using the same thumbnail issue for this and for #1670 make this submission look like a duplicate unless looking closely. Can you update one or more of these thumbnail images to differentiate the wallet image from this API image?
- This is an interesting premise that I would support in the community but would be interested in how you've documented any security concerns and especially if the API and/or wallet have been audited. I haven't looked at all the linked documentation pages but can you please share a link about audit / security assurances if available?
👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.
Checklist
<-- Please fill the boxes with [x] before submitting a pull request -->
yarn buildafter adding my changes without getting any errors.yarn.lock(or have removed these changes).Builder Tool addition
<-- Provide information for every bullet in the list below. The tags you select must match the tags in your changes to the builder-tools.js -->
chainindexcligolangIDEjavajavascriptmarlowenetnftoperatortooloracleplutuspythonrustpurescriptwebsockethttpjsonhaskelltypescriptwalletserializationsdkredissqllowleveltestinghosted