Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tui key bindings for exiting #1173

Merged
merged 4 commits into from
Nov 23, 2023
Merged

fix tui key bindings for exiting #1173

merged 4 commits into from
Nov 23, 2023

Conversation

ffakenz
Copy link
Contributor

@ffakenz ffakenz commented Nov 22, 2023


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

Copy link

github-actions bot commented Nov 22, 2023

Test Results

368 tests  ±0   363 ✔️ ±0   21m 3s ⏱️ +25s
124 suites ±0       5 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit b872cc0. ± Comparison against base commit e5da3f6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2023-11-23 10:07:18.585909023 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 57dd0a3aba3f4477afed74e7d12b6e86d7abad22ee51612ff81b4194 4059
νCommit 171a1e6bdbc8aa96d957a65b3f505517386af06ba265e3f784741f67 2050
νHead e89b0c4a6155bac2434d1e500bd49c155b2b56744ccf5a0efa72a82e 9092
μHead 92368af5649999c05211407d9a837cdd10ecf98c5829b385e89a3648* 4062
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4597 10.87 4.31 0.47
2 4798 13.25 5.23 0.51
3 5003 15.42 6.05 0.54
5 5414 19.62 7.65 0.60
10 6439 30.81 11.92 0.77
41 12796 99.44 38.11 1.79

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 537 12.23 4.81 0.31
2 723 15.93 6.48 0.36
3 911 19.77 8.20 0.41
5 1290 27.87 11.80 0.52
10 2228 50.58 21.69 0.81
18 3711 94.20 40.16 1.36

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 483 22.24 8.89 0.42
2 114 593 33.88 13.67 0.55
3 170 703 49.10 19.90 0.72
4 227 813 67.08 27.27 0.92
5 282 923 78.66 32.40 1.06

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 540 17.80 8.36 0.38
2 735 19.42 9.94 0.41
3 934 21.27 11.62 0.45
5 986 22.07 10.40 0.45
10 2177 32.56 22.47 0.67
50 8837 97.05 83.39 1.92

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 571 21.37 9.71 0.42
2 773 23.19 11.38 0.45
3 937 25.08 13.05 0.49
5 1379 28.87 16.47 0.56
10 2289 38.28 24.76 0.74
45 8159 99.69 80.12 1.89

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4536 20.14 8.77 0.58
2 4626 28.85 12.48 0.68
3 4866 50.12 22.22 0.93
4 5072 70.66 31.39 1.17
5 5122 85.74 37.92 1.34

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4416 8.98 3.78 0.44
5 1 57 4452 10.51 4.67 0.46
5 5 285 4596 15.46 7.75 0.53
5 10 570 4777 22.05 11.76 0.62
5 20 1139 5135 34.92 19.66 0.80
5 30 1708 5497 48.00 27.64 0.98
5 40 2279 5857 60.52 35.40 1.15
5 50 2846 6215 73.88 43.51 1.33
5 70 3986 6934 99.87 59.42 1.69

End-To-End Benchmark Results

This page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest master code.

Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes.

Generated at 2023-11-23 09:59:39.91598553 UTC

3-nodes Scenario

A rather typical setup, with 3 nodes forming a Hydra head.

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 24.073764615
P99 114.71902999999999ms
P95 33.56963159999999ms
P50 20.852050499999997ms
Number of Invalid txs 0

Baseline Scenario

This scenario represents a minimal case and as such is a good baseline against which to assess the overhead introduced by more complex setups. There is a single hydra-node d with a single client submitting single input and single output transactions with a constant UTxO set of 1.

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 4.270273160
P99 8.62824357999998ms
P95 5.0496499ms
P50 4.100859ms
Number of Invalid txs 0

@ffakenz ffakenz self-assigned this Nov 22, 2023
@ffakenz ffakenz linked an issue Nov 22, 2023 that may be closed by this pull request
Copy link
Collaborator

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it manually and this works for me.

Copy link
Contributor

@v0d1ch v0d1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works :shipit:

By moving global events handling as the very last step.

This successfully stops the event loop and avoids resuming.
@ch1bo ch1bo merged commit d411872 into master Nov 23, 2023
20 checks passed
@ch1bo ch1bo deleted the ffakenz/fix-tui-key-bindings branch November 23, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TUI: Navigation and exiting in dialogs broken
4 participants