Add PR review policy

[abailly-iohk]

• CHANGELOG updated or not needed
• Documentation updated or not needed
• Haddocks updated or not needed
• No new TODOs introduced or explained herafter

[github-actions]

Test Results

373 tests  ±0   368 ✔️ ±0   21m 50s ⏱️ + 1m 4s
127 suites ±0       5 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit be20aa8. ± Comparison against base commit a8ce92d.

♻️ This comment has been updated with latest results.

[github-actions]

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at	2023-12-01 13:58:16.523212232 UTC
Max. memory units	14000000
Max. CPU units	10000000000
Max. tx size (kB)	16384

Script summary

Name	Hash	Size (Bytes)
νInitial	4868d5365af5120ae0b3c93b819d3452a3cbdcc98595da2a7ae765b5	4069
νCommit	171a1e6bdbc8aa96d957a65b3f505517386af06ba265e3f784741f67	2050
νHead	e89b0c4a6155bac2434d1e500bd49c155b2b56744ccf5a0efa72a82e	9092
μHead	6849328242b5912ad218f134378e6baff11f3e74f7e36dcf8e13d53e*	4062

• The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties	Tx size	% max Mem	% max CPU	Min fee ₳
1	4585	10.75	4.26	0.47
2	4786	13.49	5.33	0.51
3	4987	15.29	6.00	0.54
5	5394	19.74	7.70	0.60
10	6393	30.94	11.98	0.77
41	12629	99.67	38.21	1.79

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO	Tx size	% max Mem	% max CPU	Min fee ₳
1	534	12.22	4.81	0.31
2	724	15.93	6.48	0.36
3	909	19.77	8.20	0.41
5	1288	27.87	11.80	0.52
10	2219	50.58	21.69	0.81
18	3712	94.20	40.16	1.36

Cost of CollectCom Transaction

Parties	UTxO (bytes)	Tx size	% max Mem	% max CPU	Min fee ₳
1	57	480	22.88	9.12	0.42
2	114	590	33.97	13.71	0.55
3	170	700	49.40	20.02	0.72
4	228	814	63.44	25.92	0.89
5	285	920	84.57	34.57	1.12

Cost of Close Transaction

Parties	Tx size	% max Mem	% max CPU	Min fee ₳
1	562	17.80	8.37	0.38
2	723	19.38	9.92	0.41
3	929	21.09	11.54	0.44
5	1210	24.13	14.42	0.50
10	2228	32.92	22.73	0.68
50	8853	96.74	83.43	1.92

Cost of Contest Transaction

Parties	Tx size	% max Mem	% max CPU	Min fee ₳
1	571	21.33	9.69	0.42
2	739	23.31	11.40	0.45
3	952	25.16	13.09	0.49
5	1317	29.09	16.50	0.56
10	2163	38.50	24.82	0.74
45	7859	98.31	78.57	1.86

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties	Tx size	% max Mem	% max CPU	Min fee ₳
1	4520	20.18	8.77	0.58
2	4694	33.84	14.90	0.74
3	4869	50.45	22.36	0.93
4	5040	69.66	30.98	1.16
5	5236	93.01	41.38	1.43

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties	UTxO	UTxO (bytes)	Tx size	% max Mem	% max CPU	Min fee ₳
5	0	0	4417	8.98	3.78	0.44
5	1	57	4452	10.51	4.67	0.46
5	5	285	4596	15.43	7.73	0.53
5	10	568	4775	22.18	11.81	0.62
5	20	1138	5134	35.02	19.70	0.80
5	30	1706	5494	48.13	27.70	0.98
5	40	2275	5853	61.12	35.65	1.16
5	50	2848	6217	73.61	43.39	1.33
5	69	3928	6897	98.80	58.72	1.68

End-To-End Benchmark Results

This page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest master code.

Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes.

Generated at 2023-12-01 13:51:01.912474812 UTC

3-nodes Scenario

A rather typical setup, with 3 nodes forming a Hydra head.

Number of nodes	3
Number of txs	900
Avg. Confirmation Time (ms)	25.147866413
P99	95.2944123399997ms
P95	34.19165855ms
P50	20.9684825ms
Number of Invalid txs	0

Baseline Scenario

This scenario represents a minimal case and as such is a good baseline against which to assess the overhead introduced by more complex setups. There is a single hydra-node d with a single client submitting single input and single output transactions with a constant UTxO set of 1.

Number of nodes	1
Number of txs	300
Avg. Confirmation Time (ms)	4.610372283
P99	6.873033109999999ms
P95	5.502740400000001ms
P50	4.4866185ms
Number of Invalid txs	0

[ch1bo]

Thanks for writing it down. It does appear a lot more strict than what we do today. I'm happy to try it out, but am afraid that approvals would become inflationary when so many are needed also for small changes. For example, the first approval is important, the following less so as people would just be needing to tick the box often.

[abailly-iohk]

@ch1bo I agree this is perhaps too restrictive a policy, I just transcribed what we said in the Tactical couple of days ago. Happy to relax the policy.