-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING: Reduce approvals for core team #1198
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
End-To-End Benchmark ResultsThis page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes. Generated at 2023-12-11 08:05:50.932665843 UTC Baseline Scenario
Baseline Scenario
|
@@ -138,7 +138,7 @@ On top of the aforementioned _Coding standards_, to get something merged would u | |||
Merging a PR requires approval from a majority of reviewers from the | |||
core _Hydra engineering_ team. This implies that: | |||
+ Contributions from outside this core team would need 3 approvals, | |||
+ Contributions from a single core team member would need 2 approvals, | |||
+ Contributions from a single core team member would need a single approval, | |||
+ PRs developed in pair would need a single approval, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consequently this would mean that pairing setups would also not need any external approval?
@@ -138,7 +138,7 @@ On top of the aforementioned _Coding standards_, to get something merged would u | |||
Merging a PR requires approval from a majority of reviewers from the | |||
core _Hydra engineering_ team. This implies that: | |||
+ Contributions from outside this core team would need 3 approvals, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be more consistent to ask for two approvals here (as the minimum quorum needed is 2?)
62af158
to
87423f4
Compare
87423f4
to
8158327
Compare
No description provided.