Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING: Reduce approvals for core team #1198

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

locallycompact
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 7, 2023

Test Results

377 tests  ±0   372 ✔️ ±0   21m 39s ⏱️ -42s
128 suites ±0       5 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 8158327. ± Comparison against base commit 6e7b43a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2023-12-11 08:02:28.348299676 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 985245919fcc6c0c5cd116023cd2c947c43e80dcbb5075fe12433fbb 4072
νCommit 7cb20fa71eb4c563ca283566ebe0aa65859d96c3f8cba35c52c181fd 2043
νHead 7a36661f5c15e9f1783aeaab890812c59b7286cbbc6de762d3110772 8816
μHead 8b111ac12274e46314769295a1c5dcab1d260096fc469fd698065463* 3851
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4374 10.34 3.99 0.46
2 4575 12.47 4.79 0.49
3 4774 14.79 5.67 0.52
5 5179 19.12 7.31 0.59
10 6184 30.43 11.61 0.75
41 12421 98.92 37.55 1.77

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 534 11.37 4.44 0.30
2 723 15.04 6.07 0.35
3 911 18.85 7.75 0.40
5 1282 26.90 11.27 0.51
10 2215 49.55 20.97 0.80
19 3904 99.43 41.75 1.43

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 480 21.78 8.51 0.41
2 113 590 33.13 13.07 0.54
3 170 700 48.71 19.31 0.71
4 225 810 58.65 23.57 0.83
5 284 920 75.93 30.63 1.03

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 570 16.64 7.68 0.37
2 736 18.40 9.30 0.40
3 888 20.22 10.92 0.43
5 1284 23.61 14.08 0.50
10 2083 31.73 21.64 0.65
50 8893 96.96 83.07 1.92

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 579 20.27 8.98 0.40
2 776 22.22 10.69 0.44
3 882 23.87 12.06 0.47
5 1276 27.70 15.52 0.54
10 2216 38.32 24.42 0.73
43 7853 99.93 77.78 1.86

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4307 18.98 8.16 0.55
2 4493 32.00 13.94 0.71
3 4629 47.58 20.87 0.89
4 4821 65.82 28.99 1.10
5 4981 87.07 38.42 1.35

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4206 8.26 3.46 0.43
5 1 57 4239 9.49 4.22 0.44
5 5 285 4375 14.19 7.18 0.51
5 10 568 4543 20.43 11.03 0.59
5 20 1140 4885 32.64 18.62 0.76
5 30 1708 5225 45.15 26.34 0.93
5 40 2275 5562 57.46 33.97 1.10
5 50 2847 5904 69.77 41.61 1.27
5 74 4217 6722 99.13 59.87 1.68

End-To-End Benchmark Results

This page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest master code.

Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes.

Generated at 2023-12-11 08:05:50.932665843 UTC

Baseline Scenario

Number of nodes 3
Number of txs 9000
Avg. Confirmation Time (ms) 24.955762841
P99 102.84951229000019ms
P95 34.410395299999976ms
P50 22.604259ms
Number of Invalid txs 0

Baseline Scenario

Number of nodes 1
Number of txs 3000
Avg. Confirmation Time (ms) 6.116832711
P99 10.92771346999993ms
P95 8.503374749999999ms
P50 5.8536465ms
Number of Invalid txs 0

@@ -138,7 +138,7 @@ On top of the aforementioned _Coding standards_, to get something merged would u
Merging a PR requires approval from a majority of reviewers from the
core _Hydra engineering_ team. This implies that:
+ Contributions from outside this core team would need 3 approvals,
+ Contributions from a single core team member would need 2 approvals,
+ Contributions from a single core team member would need a single approval,
+ PRs developed in pair would need a single approval,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consequently this would mean that pairing setups would also not need any external approval?

@@ -138,7 +138,7 @@ On top of the aforementioned _Coding standards_, to get something merged would u
Merging a PR requires approval from a majority of reviewers from the
core _Hydra engineering_ team. This implies that:
+ Contributions from outside this core team would need 3 approvals,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more consistent to ask for two approvals here (as the minimum quorum needed is 2?)

@abailly-iohk abailly-iohk merged commit ea51f67 into master Dec 12, 2023
21 of 22 checks passed
@abailly-iohk abailly-iohk deleted the lc/contributing branch December 12, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants