Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decommit endpoint #1217

Merged
merged 10 commits into from
Dec 15, 2023
Merged

Decommit endpoint #1217

merged 10 commits into from
Dec 15, 2023

Commits on Dec 14, 2023

  1. Change /decommit to accept set of TxIn 

    Also stub the endpoint
    @v0d1ch @ch1bo
    v0d1ch authored and ch1bo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c0b71dc View commit details
    Browse the repository at this point in the history

  2. Create new Decommit ClientInput and plumbing in http server

    @ch1bo
    ch1bo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    90d98fb View commit details
    Browse the repository at this point in the history

  3. Update api.yaml based on new ClientInput 

    Note that we do not document /decommit as we are not sure yet whether we
want to keep that endpoint.
    @ch1bo
    ch1bo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b6adf4a View commit details
    Browse the repository at this point in the history

  4. Switch the scenario to use the websocket API for requesting decommit 

    This "feels" a bit more consistent as requesting and processing a
decomit is an asynchronous process.
    @ch1bo
    ch1bo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c021c22 View commit details
    Browse the repository at this point in the history

  5. Add DecommitRequested to the ServerOutput

    @v0d1ch @ch1bo
    v0d1ch authored and ch1bo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f55ff2a View commit details
    Browse the repository at this point in the history

  6. Switch Decommit to take a full UTxO 

    This avoids using a concrete Cardano type in the
API (ClientInput/ServerOutput) and we can use the already existing
parametric type UTxOType for that.

Also, it will be handy to see what was requested to be decommitted.
    @ch1bo
    ch1bo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    e6a6e1d View commit details
    Browse the repository at this point in the history

  7. Use http call in decommit test 

    Remove some fixmes but also add one more in HeadLogic to remind us
to change the response to tx instead of UTxO.
    @v0d1ch
    v0d1ch committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7b96f40 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Tackle the api schema and ServerOutput encoding 

    Once we figure out exact type we want to return we will resolve FIXME in
the api schema
    @v0d1ch @ch1bo
    v0d1ch authored and ch1bo committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    8b2682c View commit details
    Browse the repository at this point in the history

  2. Switch to websocket and complete first endpoint iteration

    @ch1bo
    ch1bo committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b1be20c View commit details
    Browse the repository at this point in the history

  3. Minor modification on HTTPServerSpec

    @ch1bo
    ch1bo committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    bdd3e47 View commit details
    Browse the repository at this point in the history