DONTMERGE: Lc/ci testing

.github/workflows/binaries.yaml

@@ -13,27 +13,14 @@ jobs:
   # libraries statically linked into it.
   build-executables-linux:
     name: "Build x86_64-linux static executables"
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Checkout repository
       uses: actions/checkout@v4
       with:
         # Also ensure we have all history with all tags
         fetch-depth: 0
 
-    - name: ❄ Prepare nix
-      uses: cachix/install-nix-action@v25
-      with:
-        extra_nix_config: |
-          accept-flake-config = true
-          log-lines = 1000
-
-    - name: ❄ Cachix cache of nix derivations
-      uses: cachix/cachix-action@v14
-      with:
-        name: cardano-scaling
-        authToken: '${{ secrets.CACHIX_CARDANO_SCALING_AUTH_TOKEN }}'
-
     - name: ❄ Build static executables
       run: |
         nix build .#release-static

.github/workflows/cardano-node.yaml

@@ -9,21 +9,14 @@ on:
 jobs:
   build-executables-linux:
     name: "Build x86_64-linux static executables"
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Checkout cardano-node 8.7.2
       uses: actions/checkout@v4
       with:
         repository: IntersectMBO/cardano-node
         ref: 8.7.2
 
-    - name: ❄ Prepare nix
-      uses: cachix/install-nix-action@v25
-      with:
-        extra_nix_config: |
-          accept-flake-config = true
-          log-lines = 1000
-
     - name: ❄ Build cardano-node static executables
       run: |
         mkdir -p out/

.github/workflows/check-tutorial.yaml

@@ -13,7 +13,7 @@ on:
 jobs:
   check-tutorial:
     name: "Check tutorial"
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - uses: actions/checkout@v4
 

.github/workflows/ci-nix.yaml

@@ -18,33 +18,19 @@ on:
 jobs:
   build-test:
     name: "Build & test"
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     strategy:
       matrix:
         include:
           - package: plutus-cbor
           - package: plutus-merkle-tree
           - package: hydra-plutus
-          - package: hydra-tui
           - package: hydra-node
           - package: hydra-cluster
     steps:
     - name: 📥 Checkout repository
       uses: actions/checkout@v4
 
-    - name: ❄ Prepare nix
-      uses: cachix/install-nix-action@v25
-      with:
-        extra_nix_config: |
-          accept-flake-config = true
-          log-lines = 1000
-
-    - name: ❄ Cachix cache of nix derivations
-      uses: cachix/cachix-action@v14
-      with:
-        name: cardano-scaling
-        authToken: '${{ secrets.CACHIX_CARDANO_SCALING_AUTH_TOKEN }}'
-
     - name: ❓ Test
       if: ${{ matrix.package != 'hydra-tui' }}
       run: |
@@ -84,7 +70,7 @@ jobs:
   publish-test-results:
     name: Publish test results
     needs: [build-test]
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Download test results
       uses: actions/download-artifact@v4
@@ -99,24 +85,11 @@ jobs:
 
   haddock:
     name: "Build haddock using nix"
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Checkout repository
       uses: actions/checkout@v4
 
-    - name: ❄ Prepare nix
-      uses: cachix/install-nix-action@v25
-      with:
-        extra_nix_config: |
-          accept-flake-config = true
-          log-lines = 1000
-
-    - name: ❄ Cachix cache of nix derivations
-      uses: cachix/cachix-action@v14
-      with:
-        name: cardano-scaling
-        authToken: '${{ secrets.CACHIX_CARDANO_SCALING_AUTH_TOKEN }}'
-
     - name: 📚 Documentation (Haddock)
       run: |
         nix build .#haddocks
@@ -131,7 +104,7 @@ jobs:
 
   benchmarks:
     name: "Benchmarks"
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     strategy:
       matrix:
         include:
@@ -151,19 +124,6 @@ jobs:
     - name: 📥 Checkout repository
       uses: actions/checkout@v4
 
-    - name: ❄ Prepare nix
-      uses: cachix/install-nix-action@v25
-      with:
-        extra_nix_config: |
-          accept-flake-config = true
-          log-lines = 1000
-
-    - name: ❄ Cachix cache of nix derivations
-      uses: cachix/cachix-action@v14
-      with:
-        name: cardano-scaling
-        authToken: '${{ secrets.CACHIX_CARDANO_SCALING_AUTH_TOKEN }}'
-
     - name: 📈 Benchmark
       run: |
         mkdir -p benchmarks
@@ -190,7 +150,7 @@ jobs:
     if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository
     # TODO: this is actually only requires the tx-cost benchmark results
     needs: [benchmarks]
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Download generated documentation
       uses: actions/download-artifact@v4
@@ -224,24 +184,11 @@ jobs:
 
   build-specification:
     name: "Build specification using nix"
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Checkout repository
       uses: actions/checkout@v4
 
-    - name: ❄ Prepare nix
-      uses: cachix/install-nix-action@v25
-      with:
-        extra_nix_config: |
-          accept-flake-config = true
-          log-lines = 1000
-
-    - name: ❄ Cachix cache of nix derivations
-      uses: cachix/cachix-action@v14
-      with:
-        name: cardano-scaling
-        authToken: '${{ secrets.CACHIX_CARDANO_SCALING_AUTH_TOKEN }}'
-
     - name: ❄ Build specification PDF
       run: |
         nix build .#spec && cp result/*.pdf spec/
@@ -256,7 +203,7 @@ jobs:
   documentation:
     name: Documentation
     needs: [haddock,benchmarks,build-test,build-specification]
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Checkout repository
       uses: actions/checkout@v4

.github/workflows/docker.yaml

@@ -20,7 +20,7 @@ jobs:
       matrix:
         target: [ hydra-node, hydra-tui, hydraw, hydra-explorer ]
 
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Checkout repository
       uses: actions/checkout@v4
@@ -32,19 +32,6 @@ jobs:
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
 
-    - name: ❄ Prepare nix
-      uses: cachix/install-nix-action@v25
-      with:
-        extra_nix_config: |
-          accept-flake-config = true
-          log-lines = 1000
-
-    - name: ❄ Cachix cache of nix derivations
-      uses: cachix/cachix-action@v14
-      with:
-        name: cardano-scaling
-        authToken: '${{ secrets.CACHIX_CARDANO_SCALING_AUTH_TOKEN }}'
-
     - name: 🔨 Build image using nix
       run: |
         IMAGE_NAME=ghcr.io/${{github.repository_owner}}/${{matrix.target}}

.github/workflows/formatting.yaml

@@ -6,24 +6,11 @@ on:
 jobs:
   formatting:
     name: Check code formatting
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
     - name: 📥 Checkout repository
       uses: actions/checkout@v4
 
-    - name: ❄ Prepare nix
-      uses: cachix/install-nix-action@v25
-      with:
-        extra_nix_config: |
-          accept-flake-config = true
-          log-lines = 1000
-
-    - name: ❄ Cachix cache of nix derivations
-      uses: cachix/cachix-action@v14
-      with:
-        name: cardano-scaling
-        authToken: '${{ secrets.CACHIX_CARDANO_SCALING_AUTH_TOKEN }}'
-
     - name: 📐 Check code formatting
       run: |
         nix develop .#fmt --command treefmt --fail-on-change

.github/workflows/hlint.yaml

@@ -0,0 +1,16 @@
+name: Check hlint
+
+on:
+  pull_request:
+
+jobs:
+  hlint:
+    name: Check hlint
+    runs-on: self-hosted
+    steps:
+    - name: 📥 Checkout repository
+      uses: actions/checkout@v4
+
+    - name: 📐 Check hlint
+      run: |
+        nix develop .#fmt --command hlint .

.github/workflows/publish-docs.yaml

@@ -10,7 +10,7 @@ on:
 jobs:
   publishing:
     name: Publish Documentation
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     # if: ${{ github.event.workflow_run.conclusion == 'success' }}
     steps:
 

.hlint.yaml

@@ -0,0 +1,2 @@
+- ignore: {name: Redundant <$>, within: [Hydra.Contract.HeadTokens]}
+- ignore: {name: Redundant compare, within: [Hydra.PartySpec]}

README.md

@@ -1,5 +1,15 @@
 # <p align="center">Hydra :dragon_face:</p>
 
+
+
+
+
+
+
+
+
+
+
 <div align="center">
   <p>Implementation of the Hydra scalability protocols.</p>
   <a href='https://github.com/input-output-hk/hydra/actions'><img src="https://img.shields.io/github/actions/workflow/status/input-output-hk/hydra/ci-nix.yaml?branch=master&label=Tests&style=for-the-badge" /></a>

hydra-cardano-api/src/Hydra/Cardano/Api/ScriptHash.hs

@@ -26,5 +26,4 @@ hashScriptInAnyLang (ScriptInAnyLang _ script) =
 
 instance Arbitrary ScriptHash where
   arbitrary = do
-    plutusScript <- arbitrary
-    pure $ hashScript (PlutusScript PlutusScriptV2 plutusScript)
+    hashScript . PlutusScript PlutusScriptV2 <$> arbitrary

hydra-cardano-api/src/Hydra/Cardano/Api/TxOut.hs

@@ -167,7 +167,7 @@ fromPlutusTxOut ::
   Plutus.TxOut ->
   Maybe (TxOut CtxUTxO era)
 fromPlutusTxOut network out = do
-  value <- shelleyBasedEraConstraints (shelleyBasedEra @era) $ TxOutValueShelleyBased (shelleyBasedEra @era) <$> (toLedgerValue (maryEraOnwards @era) <$> fromPlutusValue plutusValue)
+  value <- shelleyBasedEraConstraints (shelleyBasedEra @era) (TxOutValueShelleyBased (shelleyBasedEra @era) . toLedgerValue (maryEraOnwards @era) <$> fromPlutusValue plutusValue)
   pure $ TxOut addressInEra value datum ReferenceScriptNone
  where
   addressInEra = fromPlutusAddress network plutusAddress

hydra-cluster/bench/Main.hs

@@ -1,5 +1,4 @@
 {-# LANGUAGE DuplicateRecordFields #-}
-{-# LANGUAGE OverloadedRecordDot #-}
 
 module Main where
 

hydra-cluster/src/Hydra/Cluster/Mithril.hs

@@ -52,14 +52,14 @@ downloadLatestSnapshotTo tracer network directory = do
 
   genesisKeyURLForNetwork :: KnownNetwork -> Maybe String
   genesisKeyURLForNetwork = \case
-    Mainnet -> Just $ "https://raw.githubusercontent.com/input-output-hk/mithril/main/mithril-infra/configuration/release-mainnet/genesis.vkey"
-    Preproduction -> Just $ "https://raw.githubusercontent.com/input-output-hk/mithril/main/mithril-infra/configuration/release-preprod/genesis.vkey"
-    Preview -> Just $ "https://raw.githubusercontent.com/input-output-hk/mithril/main/mithril-infra/configuration/pre-release-preview/genesis.vkey"
-    Sanchonet -> Just $ "https://raw.githubusercontent.com/input-output-hk/mithril/main/mithril-infra/configuration/testing-sanchonet/genesis.vkey"
+    Mainnet -> Just "https://raw.githubusercontent.com/input-output-hk/mithril/main/mithril-infra/configuration/release-mainnet/genesis.vkey"
+    Preproduction -> Just "https://raw.githubusercontent.com/input-output-hk/mithril/main/mithril-infra/configuration/release-preprod/genesis.vkey"
+    Preview -> Just "https://raw.githubusercontent.com/input-output-hk/mithril/main/mithril-infra/configuration/pre-release-preview/genesis.vkey"
+    Sanchonet -> Just "https://raw.githubusercontent.com/input-output-hk/mithril/main/mithril-infra/configuration/testing-sanchonet/genesis.vkey"
 
   aggregatorEndpointForNetwork :: KnownNetwork -> Maybe String
   aggregatorEndpointForNetwork = \case
-    Mainnet -> Just $ "https://aggregator.release-mainnet.api.mithril.network/aggregator"
-    Preproduction -> Just $ "https://aggregator.release-preprod.api.mithril.network/aggregator"
-    Preview -> Just $ "https://aggregator.pre-release-preview.api.mithril.network/aggregator"
-    Sanchonet -> Just $ "https://aggregator.testing-sanchonet.api.mithril.network/aggregator"
+    Mainnet -> Just "https://aggregator.release-mainnet.api.mithril.network/aggregator"
+    Preproduction -> Just "https://aggregator.release-preprod.api.mithril.network/aggregator"
+    Preview -> Just "https://aggregator.pre-release-preview.api.mithril.network/aggregator"
+    Sanchonet -> Just "https://aggregator.testing-sanchonet.api.mithril.network/aggregator"

hydra-cluster/test/Test/Hydra/Cluster/CardanoCliSpec.hs

@@ -42,15 +42,15 @@ spec =
       it "query protocol-parameters is compatible with our FromJSON instance" $ \tracer ->
         withTempDir "hydra-cluster" $ \tmpDir -> do
           withCardanoNodeDevnet tracer tmpDir $ \RunningNode{nodeSocket, networkId} -> do
-            protocolParameters <- cliQueryProtocolParameters nodeSocket (networkId)
-            case (parseEither pparamsFromJson protocolParameters) of
+            protocolParameters <- cliQueryProtocolParameters nodeSocket networkId
+            case parseEither pparamsFromJson protocolParameters of
               Left e -> failure $ "Failed to decode JSON: " <> e <> "\n" <> show protocolParameters
               Right _ -> pure ()
 
       it "query protocol-parameters matches our schema" $ \tracer ->
         withJsonSpecifications $ \tmpDir ->
           withCardanoNodeDevnet tracer tmpDir $ \RunningNode{nodeSocket, networkId} -> do
-            pparamsValue <- cliQueryProtocolParameters nodeSocket (networkId)
+            pparamsValue <- cliQueryProtocolParameters nodeSocket networkId
             validateJSON
               (tmpDir </> "api.json")
               (key "components" . key "schemas" . key "ProtocolParameters")