Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "get involved" page #1527

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

oduameh
Copy link
Contributor

@oduameh oduameh commented Jul 23, 2024


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@olgahryniuk
Copy link
Collaborator

Kind request to the Hydra team; can you please fix several things with this PR:

  • The proposed 'Get involved' section should be placed under FAQs (if everyone agrees)

  • There are several inconsistencies with titles in 'Use cases' - the ones on the navigation should also follow the 'Sentence case' approach:

    • Change 'Inter-Wallet Payments' to 'Inter-wallet payments' in the navigation bar
    • Change 'Pay-Per-Use API' to 'Pay-per-use API' in the navigation bar
    • Change 'Poker Game' to 'Poker game' in the navigation bar.

    We will appreciate your support, as we can't find specific files to make these changes.

    cc @ffakenz @noonio @ch1bo

@olgahryniuk olgahryniuk marked this pull request as ready for review July 23, 2024 13:43
@olgahryniuk olgahryniuk added the documentation 📖 Documentation changes label Jul 23, 2024
@noonio
Copy link
Contributor

noonio commented Jul 23, 2024

@olgahryniuk
Copy link
Collaborator

Thanks, @noonio.
@oduameh, please provide the team with editing rights

@oduameh
Copy link
Contributor Author

oduameh commented Jul 23, 2024

You'll need to check this - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork - to enable us to edit the branch on the fork

Hi @noonio I have just sent you a collaboration request

@noonio
Copy link
Contributor

noonio commented Jul 29, 2024

Those changes have been made now @olgahryniuk

image
image

@noonio noonio requested a review from a team July 29, 2024 10:20
@noonio noonio self-assigned this Jul 29, 2024
@ch1bo ch1bo added this to the 0.18.0 milestone Jul 29, 2024
@ch1bo ch1bo changed the title Mk 5521 getting involved Add getting involved page Jul 29, 2024
@ch1bo ch1bo changed the title Add getting involved page Add "get involved" page Jul 29, 2024
@ch1bo ch1bo merged commit e1745f2 into cardano-scaling:master Jul 29, 2024
18 checks passed
@noonio noonio deleted the MK-5521-getting-started branch July 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants