Replaced inter-process to intra-process image handling #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Addresses #5. Signed-off-by: Bey Hao Yun <[email protected]>
… it already deploys both virtual_camera and image_viewer nodes. Signed-off-by: Bey Hao Yun <[email protected]>
…lement. Signed-off-by: Bey Hao Yun <[email protected]>
…2 launch barriers. Allow for intra-process to run more dynamically and user-friendliness. Signed-off-by: Bey Hao Yun <[email protected]>
…ead of ros2 launch. Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
…h.py parameter declaration and handling. Signed-off-by: Bey Hao Yun <[email protected]>
… more informative label of use_image_viewer. Signed-off-by: Bey Hao Yun <[email protected]>
…dynamically-ran ImageViewer ROS 2 node for intra-process operation. Closes #5. Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This?
The purpose of this pull request is to address long-standing issue #5 on improving
virtual_camera's memory efficiency by using intra-process through the call of[SingleThreadedExecutor](rclcpp::executors::SingleThreadedExecutor). This aims to allow for better user experience using the package for users sincevirtual_camerashould only play a minimal systemic role in whichever development workflow a ROS 2 developer adopts for whichever complex architecture of ROS 2 node.