update start-base script with full URL and cleanup comments

cardstack · Jan 13, 2025 · e0a83a9 · e0a83a9
1 parent c55ed0c
commit e0a83a9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -84,7 +84,7 @@ Instead of running `pnpm start:base`, you can alternatively use `pnpm start:all`
 | :4205 | `/test` realm for matrix client tests (playwright controlled) | 🚫                  | 🚫                   |
 | :4210 | Development Worker Manager (spins up 1 worker by default)     | ✅                  | 🚫                   |
 | :4211 | Test Worker Manager (spins up 1 worker by default)            | ✅                  | 🚫                   |
-| :4212 | Test Worker Manager for matrix client tests (playwright controlled - 1 worker) | ✅                  | 🚫                   |
+| :4212 | Test Worker Manager for matrix client tests (playwright controlled - 1 worker) | ✅ | 🚫                   |
 | :5001 | Mail user interface for viewing emails sent to local SMTP     | ✅                  | 🚫                   |
 | :5435 | Postgres DB                                                   | ✅                  | 🚫                   |
 | :8008 | Matrix synapse server                                         | ✅                  | 🚫                   |

diff --git a/packages/matrix/helpers/isolated-realm-server.ts b/packages/matrix/helpers/isolated-realm-server.ts
@@ -31,7 +31,7 @@ export async function startServer() {
   process.env.MATRIX_URL = 'http://localhost:8008';
   process.env.REALM_SERVER_MATRIX_USERNAME = 'realm_server';
 
-  let worker = spawn(
+  let workerManager = spawn(
     'ts-node',
     [
       `--transpileOnly`,
@@ -50,13 +50,13 @@ export async function startServer() {
       stdio: ['pipe', 'pipe', 'pipe', 'ipc'],
     },
   );
-  if (worker.stdout) {
-    worker.stdout.on('data', (data: Buffer) =>
+  if (workerManager.stdout) {
+    workerManager.stdout.on('data', (data: Buffer) =>
       console.log(`worker: ${data.toString()}`),
     );
   }
-  if (worker.stderr) {
-    worker.stderr.on('data', (data: Buffer) =>
+  if (workerManager.stderr) {
+    workerManager.stderr.on('data', (data: Buffer) =>
       console.error(`worker: ${data.toString()}`),
     );
   }

diff --git a/packages/realm-server/scripts/start-base.sh b/packages/realm-server/scripts/start-base.sh
@@ -26,4 +26,4 @@ NODE_ENV=development \
   --path='../base' \
   --username='base_realm' \
   --fromUrl='https://cardstack.com/base/' \
-  --toUrl='/base/'
+  --toUrl='http://localhost:4201/base/'