Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete in search resource #1995

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix delete in search resource #1995

merged 1 commit into from
Jan 2, 2025

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Dec 31, 2024

Essentially, the instances array returned from the search resource [undefined, ...] bcos of the delete action

Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   20m 35s ⏱️ +6s
721 tests ±0  719 ✔️ ±0  2 💤 ±0  0 ±0 
726 runs  ±0  724 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit fa5665d. ± Comparison against base commit cfd2579.

@tintinthong tintinthong changed the title Fix delete in work tracker Fix delete in search resource Dec 31, 2024
@tintinthong
Copy link
Contributor Author

Its likely this is a workaround that doesn't address the original issue

@tintinthong
Copy link
Contributor Author

After pairing session with @habdelra, the main reason is that card resources clear the card instance upon receiving a 404 (assuming the card has deleted).

this.clearCardInstance();

The current fix is correct to only return searches that has card instances

@tintinthong tintinthong merged commit 34741a3 into main Jan 2, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants