Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach tool call results to the call & trigger responses on tool calls #2023

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

IanCal
Copy link
Contributor

@IanCal IanCal commented Jan 9, 2025

Connects the command output to the original tool call event.

I had to change what we were doing with the event ids to get them to line up.

Issues

  • We respond for every message from the user, so if there's results from two command executions then it replies with two things right now

Auto running for a small weather example with a custom embedded template
image

@IanCal IanCal requested a review from lukemelia January 9, 2025 15:05
Copy link

github-actions bot commented Jan 9, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   21m 19s ⏱️ +45s
726 tests ±0  724 ✔️ ±0  2 💤 ±0  0 ±0 
731 runs  ±0  729 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 258458f. ± Comparison against base commit 5a125c0.

♻️ This comment has been updated with latest results.

@IanCal
Copy link
Contributor Author

IanCal commented Jan 9, 2025

@lukemelia I'm wondering if something has gotten broken with the event IDs when there's streaming on the host side - the fix may not be to change it here. I think we've recently lost streaming which could be related?

@Hynaotar
Copy link

Connects the command output to the original tool call event.

I had to change what we were doing with the event ids to get them to line up.

Issues

  • We respond for every message from the user, so if there's results from two command executions then it replies with two things right now

Auto running for a small weather example with a custom embedded template

image

@IanCal IanCal merged commit 2275c7e into main Jan 14, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants