CS-7790 CS-7791 New CRM task tab and planner #2042
Conversation
| index?: number; | ||
| } | ||
|
|
||
| export class CRMTaskPlannerIsolated extends Component<typeof CRMTaskPlanner> { |
There was a problem hiding this comment.
was hoping there was more re-use of a component here. Can we extract a component from the isolated work tracker first.
If I had a list of todos and days of the week, cud I make a work tracker from that using the same template
There was a problem hiding this comment.
@tintinthong indeed it's a good time to extract and reuse the base task planner component before it grows up on other use cases.
In this new base task planner component, we are able to pass dynamic columns config from the consumer level. Hence its doable on your scenario to map columns by days of the week inside the config
You may see some examples within the sprint planner and crm task planner in this PR, thanks
| columns: TaskColumn[]; | ||
| } | ||
|
|
||
| export class BaseTaskPlannerIsolated< |
There was a problem hiding this comment.
Is it more straightforward to get this to be a GlimmerComponent that is used inside the isolated template?
There was a problem hiding this comment.
@tintinthong I was trying GlimmerComponent with straightforward type declaration like this
export class BaseTaskPlannerIsolated extends GlimmerComponent<BaseTaskPlannerIsolatedSignature> {
It turns out there is a bunch of lint errors because the base task planner is not extending to the type to SprintPlanner/TaskPlanner
https://github.com/cardstack/boxel/actions/runs/12823222126/job/35757386460?pr=2042
If I use something like this with GlimmerComponent it works now, but not sure is more straightforward
export class BaseTaskPlannerIsolated<
T extends typeof CardDef = typeof CardDef,
> extends GlimmerComponent<
BaseTaskPlannerIsolatedSignature & { Args: { model: InstanceType<T> } }
> {
There was a problem hiding this comment.
I reverted to original approach
richardhjtan
force-pushed
the
CS-7791-crm-task-planner
branch
from
23acc8b to
71bb5ba
Compare
This reverts commit 71bb5ba.
|
Ticket for refactoring: https://linear.app/cardstack/issue/CS-7888/refactor-task-planner-component |
Refer to
What is changing
Tasktab in CRM appCRM Task Planner
CRM Task
TaskContactwith Representative as assignee because our representative (staff) save as contact right nowAccountDealScreenshot
