-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem 1.1 - New test helper and tests for problem 1.1 #69
base: master
Are you sure you want to change the base?
Problem 1.1 - New test helper and tests for problem 1.1 #69
Conversation
Looks good so far, let me review it some time later in the week. Thanks for the PR! 🎉 |
Let me know if there any comments or concerns or any way I can improve! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway to simplify so that the cost of rewriting is not too high? Something like changing console.log
to test
only. You can make the test descriptions optional.
Okay, let me rethink and come back. Thank you @profnandaa. In addition, just so we are on the same page, it's not just as simple as replacing For some of them, it can be very easily translatable... For example: Again, this is mainly just aesthetics and better testing. The Do you want me to go ahead and make the |
I was thinking of something like: test(fn(params), expectedResults); Then abstract all the nice stuff under |
DISCLAIMER: This is my first time in a while forking and making a PR.
I recently came across this repo and I am willing to contribute the best I can.
This PR aims to solve 2 problems:
For example, if you open up any of the problems in the repo, like this one, you will accidentally see the solution. There should be a separate place where people can JUST attempt the problems after they have read the problem from the book.
This way, we can still offer a set of test cases which users can test against, while still abiding by Gayle's order that is:
The caveats to merging:
This is a small PR but a big feature. This would require:
index.js
) across all the problems in all the chaptersconsole.log
tests to instead to have the newtest()
testPlease comment, edit or provide criticism to the PR. But in general, I think the playground is a feature we should be going for!