Skip to content

fix(region-admin): resolve stale merge markers in CreateCenterDialog.tsx - #7

Open
TheBoomerDev wants to merge 1 commit into
mainfrom
chore/faseD-vitest-hygiene
Open

fix(region-admin): resolve stale merge markers in CreateCenterDialog.tsx#7
TheBoomerDev wants to merge 1 commit into
mainfrom
chore/faseD-vitest-hygiene

Conversation

@TheBoomerDev

@TheBoomerDev TheBoomerDev commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

App.test.tsx fixture compilation was crashing on esbuild Unexpected "<<" because src/components/region-admin/CreateCenterDialog.tsx line 14-26 contained unresolved git merge-conflict markers from prior WIP. Same root cause hides two pre-existing TS errors (TS6196 + TS2339) that only surfaced once the markers stopped blocking tsc.

Fix (single file, +12/-3)

  • Removed 3 marker lines + the empty origin/main branch.
  • Adopted the existing UserWithRegion interface in BOTH .filter() and .map() callbacks (previously typed as Record<string, unknown>).

Validation on PR branch vs origin/main

Check Result
npx tsc -b --noEmit clean
npx vitest run src/App.test.tsx 9/9 pass (was blocked at fixture transform before this PR)

Out of scope (deferred require source-feature co-landing)

  • ExerciseForm.test.tsx — jest→vi migration + latent test-logic fix.
  • CreateUserDialog.test.tsx — tighter partial-mock cast.

These reference source modules (ExerciseForm.tsx, CreateUserDialog.tsx) not on origin/main yet. They land with their source-feature PRs or as a follow-up combined hygiene+source batch.

  • PlatformPresets.test.tsx + SecurityMonitoringDashboard.export.test.tsx cleanup modernization — already modernized at HEAD, no PR change needed.

…rge markers

App.test.tsx fixture compilation crashed on esbuild's 'Unexpected <<' because src/components/region-admin/CreateCenterDialog.tsx:14-26 contained unresolved git merge-conflict markers from prior WIP. This single-file fix removes the 3 marker lines + the empty 'origin/main' branch and adopts the existing UserWithRegion interface in .filter()/.map() (previously Record<string, unknown>, which had TS errors hidden by the markers).
@TheBoomerDev
TheBoomerDev force-pushed the chore/faseD-vitest-hygiene branch from 12945e1 to b5d0d18 Compare June 30, 2026 22:23
@TheBoomerDev TheBoomerDev changed the title test(hygiene): Fase D — jest→vi migration + cleanup modernization + unblock App.test via merge-marker fix fix(region-admin): resolve stale merge markers in CreateCenterDialog.tsx Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant