Add support for a .Delay(x) for recurrent jobs #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ocassions we want to add some delay to a recurrent job that is different to the recurrent period itself. We add a .Delay(time) method to add such delay. It returns the given time on the first call of nextRun()
We want .Delay(x) to work in a similar way to Every(x), where you
can pass the duration unit after.
This results in more significant syntax:
scheduler.Every(5).Minutes().Delay(10).Seconds().Run(job)
To get 100% coverage
keymon
force-pushed
the
add_delayed_start
branch
from
2acdc42 to
c8fecd8
Compare
|
Not sure why travis fails for go1.2, it seems it does not install the cover tool. I tried to reproduce it myself with go1.2.2, but I couldn't. |
|
Hello @carlescere, any feedback about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ocassions we want to add some delay to a recurrent job that is different to the recurrent period itself.
I add a
.Delay()modifier that changes the time for the initial delay. Thisin incompatible to
NotImmediatelly().I added here two possible implementation in two different commits:
.Delay(10 * time.Second): we pass atime.Durationdirectly.Delay(10).Seconds(): more complex and magic behaviour, it behaveslike
Every(x), but nicer to readLet me know which one you like the most and I can rebase this PR (or just merge it if you like it :))