Require ActiveSupport

[benhutton]

This fixes #297.

[apotheon]

I tested this change with a gem that requires carmen, and it works flawlessly. My only question is whether require 'active_support/core_ext/string' is still needed. It does not appear necessary at all.

This change, in and of itself, appears to fix the issue in question, though. I approve it. If anyone is unsure about the need for the other require line, and wants to investigate further, I see no reason to hold up this fix in the mean time.

[benhutton]

@apotheon it looks like the other require line came in through 5d456f5. Some of that code is still in use today.

require 'active_support' doesn't actually require any of the libraries inside of AS. You still need to do that individually. require 'active_support' is basically setup code. See https://guides.rubyonrails.org/active_support_core_extensions.html#stand-alone-active-support for more details!

[apotheon]

Thanks. I stand corrected regarding the other require.

[apotheon]

@benhutton - How do you feel about maintaining a fork and pulling in code from pull requests already submitted as needed? Perhaps name it "SanDiego" and publish it as a gem. That's assuming you know the codebase well enough and have time to be a maintainer.

[benhutton]

@apotheon I definitely don't know this codebase at all! Sorry