Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Output Control Implementation errors #34

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

Ay1tsMe
Copy link
Contributor

@Ay1tsMe Ay1tsMe commented Aug 8, 2023

Description:

The following are corrections in the output_control and set_output_control functions that fix the following errors:

  1. Unable to retrieve outputs on the alarm.
    This was due to indentation errors in the function. The output array was never populated because the code was indented to execute only if their was no response.

  2. Unknown vendor when switching on and off an output
    Because the if statement that checks the self.vendor was executed before the login() function was called, the function would always return the following error:

2023-08-08 20:35:34,527 - ERROR - Output control not implemented for vendor Unknown

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.34% ⚠️

Comparison is base (87854ae) 66.94% compared to head (b17defc) 66.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   66.94%   66.61%   -0.34%     
==========================================
  Files           6        6              
  Lines        1186     1192       +6     
  Branches      283      286       +3     
==========================================
  Hits          794      794              
- Misses        290      296       +6     
  Partials      102      102              
Files Changed Coverage Δ
ultrasync/main.py 59.76% <0.00%> (-0.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit e453464 into caronc:master Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants