Fixed Output Control Implementation errors #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The following are corrections in the
output_control
andset_output_control
functions that fix the following errors:Unable to retrieve outputs on the alarm.
This was due to indentation errors in the function. The
output
array was never populated because the code was indented to execute only if their was no response.Unknown vendor when switching on and off an output
Because the
if
statement that checks theself.vendor
was executed before thelogin()
function was called, the function would always return the following error: