Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix un-rendered callout by changing it to a note #428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix un-rendered callout by changing it to a note #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions episodes/41-code-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,19 +308,14 @@ There is doing to be an exercise next for you to practice it.
repository as a collaborator.
You will have to do the same for the collaborator doing the review on your repository.

::::::::::::::::::::::::::::::::::::::::: callout

## Code Review from External Contributors

You do not have to be a collaborator on a public repository to do code reviews
**Note:** *You do not have to be a collaborator on a public repository to do code reviews
so this step is not strictly necessary.
We are still asking you to do it now as we will get you working in teams
for the rest of the course so it may make sense to start setting up your collaborators now.
for the rest of the course so it may make sense to start setting up your collaborators now - as
shown in the screenshot below.*

![](fig/github-add-collaborator.png){alt='Adding a collaborator in GitHub' .image-with-shadow width="900px"}

::::::::::::::::::::::::::::::::::::::::::::::::::

2. Locate up the pull request from the GitHub's `Pull Requests` tab on the home page
of your fellow learner's software repository, then head to the `Files changed` tab
on the pull request.
Expand Down