Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01-getting-started-with-nextflow.md with correct input fq.gz path #110

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

emmcauley
Copy link
Contributor

Input fq.gz path given in "Your First Script" was params.input = "data/untrimmed_fastq/SRR2584863_1.fastq.gz instead of data/yeast/reads/ref1_1.fq.gz, which is the path given in the solution.

A straight-up copy + paste of the script produced the following output for me:

N E X T F L O W  ~  version 23.10.1
Launching `word_count.nf` [loving_chandrasekhar] DSL2 - revision: 72656509cb
executor >  local (1)
[60/c575b8] process > NUM_LINES (1) [100%] 1 of 1 ✔
SRR2584863_1.fastq.gz	0

which could be changed by overriding the params.input argument (nextflow run word_count.nf --input data/yeast/ref1_1.fq.gz:

N E X T F L O W  ~  version 23.10.1
Launching `word_count.nf` [friendly_dubinsky] DSL2 - revision: 72656509cb
executor >  local (1)
[aa/a655c0] process > NUM_LINES (1) [100%] 1 of 1 ✔
ref1_1.fq.gz	58708

This new output matches the solution given under Running Nextflow scripts > Show me the solution

Input fq.gz path given in "Your First Script" was `params.input = "data/untrimmed_fastq/SRR2584863_1.fastq.gz` instead of `data/yeast/reads/ref1_1.fq.gz`, which is the path given in the solution.
Copy link

github-actions bot commented Mar 27, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/workflows-nextflow/compare/md-outputs..md-outputs-PR-110

The following changes were observed in the rendered markdown documents:

 01-getting-started-with-nextflow.md | 2 +-
 02-workflow_parameters.md           | 2 +-
 md5sum.txt                          | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-03-28 11:40:11 +0000

github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
@ggrimes ggrimes merged commit e58e1d7 into carpentries-incubator:main Mar 28, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
Auto-generated via {sandpaper}
Source  : e58e1d7
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-03-28 11:40:54 +0000
Message : Merge pull request #110 from emmcauley/patch-1

Update 01-getting-started-with-nextflow.md with correct input fq.gz path
github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
Auto-generated via {sandpaper}
Source  : 3a4bb82
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-28 11:41:53 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e58e1d7
Branch  : main
Author  : Graeme Grimes <[email protected]>
Time    : 2024-03-28 11:40:54 +0000
Message : Merge pull request #110 from emmcauley/patch-1

Update 01-getting-started-with-nextflow.md with correct input fq.gz path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants