Response to Lex Nederbragt review #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-wilson
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Good good to me, thanks for making these changes @ewallace 😄
5 tasks
|
I've gone through addressing most points in the review. Big things left:
|
- Record different data types in individual tables as appropriate (e.g. sample metadata may be kept separately from sequencing experiment metadata) - Use unique identifiers for every record in a table, allowing linkages between tables (e.g. sample identifiers are recorded in the sequencing experiment metadata) Addresses #44
added 4 commits
June 12, 2023 11:53
Simplified exercise by giving learners the function and asking them to call the function with different parameters, then use the function within a for loop.
ameynert
approved these changes
Jun 12, 2023
ewallace
changed the title
Update lex-review-response branch before merge.
zkamvar
pushed a commit
that referenced
this pull request
Aug 31, 2023
* Summary and clarifications in 02-data_management.md * Clarifications in 04-collaboration.md * Simplify recap in 08-what_next.md * changelog explanation and minor edits to 06-track_changes.md * Clarify 05-project_organization.md * Links, clarifications, in 05-project_organization.md * Attribution to GEP paper in 02-data_management.md * Attribute GEP paper in 03-software.md * Attribute GEP paper in 04-collaboration.md * Attribute GEP paper in 06-track_changes.md * Attribute GEP paper in 07-manuscripts.md * Add links in 03-software.md * More links in 03-software.md * Intro discussion notes in instructor guide * Added links to resources on file naming Addresses #42 * Clarified use of multiple tables - Record different data types in individual tables as appropriate (e.g. sample metadata may be kept separately from sequencing experiment metadata) - Use unique identifiers for every record in a table, allowing linkages between tables (e.g. sample identifiers are recorded in the sequencing experiment metadata) Addresses #44 * Modifications to pseudocode exercise Simplified exercise by giving learners the function and asking them to call the function with different parameters, then use the function within a for loop. * Link fix for Azure * Section heading change for multiple tables * Expanded glossary --------- Co-authored-by: ameynert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT response to Lex Nederbragt review at carpentries-lab/reviews#24 (comment)