Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.yaml for carpentries lab transition #128

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Conversation

ewallace
Copy link
Collaborator

  • lesson changed to stable status, fixes Update lesson from beta #124
  • carpentry changed from incubator to lab
  • source changed to point to the new repository URL (before the transfer to carpentries-lab organisation though)

created as draft as should be updated/completed after move to carpentries-lab

- lesson changed to stable status
- carpentry changed from incubator to lab
- source changed to point to the new repository URL (before the transfer to carpentries-lab organisation though)
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-lab/good-enough-practices/compare/md-outputs..md-outputs-PR-128

The following changes were observed in the rendered markdown documents:

 config.yaml                    | 32 +++++++++++---------------
 discuss.md (gone)              |  9 --------
 etherpad_template.md           |  3 ++-
 learner-profiles.md            | 51 ++++++++++++++++++++++++++++++++++++++++--
 md5sum.txt                     | 11 ++++-----
 reference.md (gone)            | 21 -----------------
 teaching_guide_for_etherpad.md |  5 +++--
 7 files changed, 71 insertions(+), 61 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-07 11:54:47 +0000

github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@ewallace ewallace marked this pull request as ready for review September 7, 2023 11:13
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
@ewallace ewallace requested a review from alee September 7, 2023 11:22
@ewallace
Copy link
Collaborator Author

ewallace commented Sep 7, 2023

@tobyhodges I'm requesting review on this now we've migrated to carpentries-lab, thank you! Do we have the metadata right?

I seem to have something wrong in my local preview that the etherpad template and teaching guide aren't coming up. Does anyone know how to fix that? I requested review from @alee for that reason.

Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to config.yaml are exactly what's needed. To get your extra pages for Instructors to show up in the menu, set a title for them in the YAML header of their Markdown source files.

github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
@ewallace ewallace merged commit a8844da into main Sep 7, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
Auto-generated via {sandpaper}
Source  : a8844da
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-07 11:59:21 +0000
Message : Merge pull request #128 from carpentries-lab/124-config-lab

- Update config.yaml for carpentries lab transition
- Add titles to instructor materials

Thank you @tobyhodges, that was an easy fix. Merging now.
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
Auto-generated via {sandpaper}
Source  : f727bb2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-07 12:01:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a8844da
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-07 11:59:21 +0000
Message : Merge pull request #128 from carpentries-lab/124-config-lab

- Update config.yaml for carpentries lab transition
- Add titles to instructor materials

Thank you @tobyhodges, that was an easy fix. Merging now.
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Auto-generated via {sandpaper}
Source  : f727bb2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-07 12:01:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a8844da
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-07 11:59:21 +0000
Message : Merge pull request #128 from carpentries-lab/124-config-lab

- Update config.yaml for carpentries lab transition
- Add titles to instructor materials

Thank you @tobyhodges, that was an easy fix. Merging now.
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Auto-generated via {sandpaper}
Source  : f727bb2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-07 12:01:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a8844da
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-07 11:59:21 +0000
Message : Merge pull request #128 from carpentries-lab/124-config-lab

- Update config.yaml for carpentries lab transition
- Add titles to instructor materials

Thank you @tobyhodges, that was an easy fix. Merging now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update lesson from beta
2 participants