Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embed captions in image figures #131

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

alee
Copy link
Member

@alee alee commented Aug 31, 2023

I think this covers all of the image captions that needed adjustment. I also made the text for both phdcomics sources consistent with each other.

https://carpentries.github.io/workbench/transition-guide.html#figures

closes #130

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/good-enough-practices/compare/md-outputs..md-outputs-PR-131

The following changes were observed in the rendered markdown documents:

 02-data_management.md | 4 ++--
 06-track_changes.md   | 4 ++--
 md5sum.txt            | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-08-31 19:38:47 +0000

github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@ewallace ewallace merged commit 6be084a into carpentries-lab:main Sep 7, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
Auto-generated via {sandpaper}
Source  : 6be084a
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-07 11:05:49 +0000
Message : Merge pull request #131 from comses-education/fix_captions

fix: embed captions in image figures

I reviewed the changes and previewed locally, looks good, merging.
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
Auto-generated via {sandpaper}
Source  : 9e11ca4
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-07 11:08:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6be084a
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-07 11:05:49 +0000
Message : Merge pull request #131 from comses-education/fix_captions

fix: embed captions in image figures

I reviewed the changes and previewed locally, looks good, merging.
@alee alee deleted the fix_captions branch September 15, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix figure captions
2 participants