Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move learner-profiles.md into /profiles #132

Merged

Conversation

alee
Copy link
Member

@alee alee commented Aug 31, 2023

closes #129

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/good-enough-practices/compare/md-outputs..md-outputs-PR-132

The following changes were observed in the rendered markdown documents:

 learner-profiles.md | 51 +++++++++++++++++++++++++++++++++++++++++++++++++--
 md5sum.txt          |  3 +--
 2 files changed, 50 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-08-31 19:51:01 +0000

github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@ewallace ewallace merged commit e415660 into carpentries-lab:main Sep 7, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
Auto-generated via {sandpaper}
Source  : e415660
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-07 11:07:20 +0000
Message : Merge pull request #132 from comses-education/update_learner_profiles

fix: move learner-profiles.md into /profiles

I have previewed this locally and see the learner profiles. Thank you so much @alee!
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
Auto-generated via {sandpaper}
Source  : e27db85
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-07 11:08:29 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e415660
Branch  : main
Author  : Edward Wallace <[email protected]>
Time    : 2023-09-07 11:07:20 +0000
Message : Merge pull request #132 from comses-education/update_learner_profiles

fix: move learner-profiles.md into /profiles

I have previewed this locally and see the learner profiles. Thank you so much @alee!
@alee alee deleted the update_learner_profiles branch September 15, 2023 22:32
@alee alee restored the update_learner_profiles branch September 15, 2023 22:32
@alee alee deleted the update_learner_profiles branch September 15, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display learner profiles
2 participants