Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace absolute links with relative links #145

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

alee
Copy link
Member

@alee alee commented Mar 4, 2024

replace absolute urls in episode 2 with relative links so they should always resolve regardless of where they were deployed

see https://carpentries.github.io/sandpaper-docs/episodes.html#internal-links for more details

fixes #142

Copy link

github-actions bot commented Mar 4, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-lab/good-enough-practices/compare/md-outputs..md-outputs-PR-145

The following changes were observed in the rendered markdown documents:

 02-data_management.md | 4 ++--
 md5sum.txt            | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-03-04 22:21:43 +0000

github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
@alee alee merged commit db169b1 into carpentries-lab:main Mar 5, 2024
3 checks passed
@alee alee deleted the update_relative_links branch March 5, 2024 07:55
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
Auto-generated via {sandpaper}
Source  : 1874bc5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 07:56:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
github-actions bot pushed a commit that referenced this pull request Mar 12, 2024
Auto-generated via {sandpaper}
Source  : 1874bc5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 07:56:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
github-actions bot pushed a commit that referenced this pull request Mar 19, 2024
Auto-generated via {sandpaper}
Source  : 1874bc5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 07:56:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
Auto-generated via {sandpaper}
Source  : 1874bc5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 07:56:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
Auto-generated via {sandpaper}
Source  : 1874bc5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 07:56:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
Auto-generated via {sandpaper}
Source  : 1874bc5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 07:56:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
Auto-generated via {sandpaper}
Source  : 1874bc5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 07:56:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
Auto-generated via {sandpaper}
Source  : 1874bc5
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-05 07:56:05 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : db169b1
Branch  : main
Author  : Allen Lee <[email protected]>
Time    : 2024-03-05 07:55:14 +0000
Message : Merge pull request #145 from comses-education/update_relative_links

fix: replace absolute links with relative links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken link in episode 2
1 participant