exclude lockfile packages from hydration #533
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly enough, this has solved a long frustration that I've had where hydration would over-saturate and install packages that were already in the lockfile. The restore takes care of that step, even if the user does not have the packages locally. The result of this is a really big speedup for rebuilding lessons that are out of date with packages as in the case of the bioc-rnaseq: time for sandpaper 0.14.1: 1m 15s The downside is that I'm finding that lessons with no cache are building the packages from source (possibly because the binaries are only the up-to-date ones), such as librarycarpentry/lc-r taking 29m to build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where a GitHub package would fail to be provisioned even if it is recorded in the lockfile.
(see #221 (comment))
NOTE: I am trying a patch release here directly from the 0.14.0 tag.