Make CLI in line with intended default for increment_micro

[znichollscr]

@carstencodes I think this would fix #326,
but I'm not certain about any side effects.

A different solution would be to use store_const
and have different None handling, see e.g.
https://docs.python.org/3/library/argparse.html.
Again, not sure of side effects.

[znichollscr]

Hmm the fact that the tests still pass also suggest there's a missing test case somewhere..

[carstencodes]

Yeah, tests are not fully covered yet.

Currently, changing the command-line argument would introduce a breaking change.

Sorry for being a little cautious about this, but I might find a workaround using meta-vars...

Give me a day or two

[znichollscr]

No problem, take your time

[znichollscr]

As far as I could tell, the CLI is setting the increment_micro option so the defaults deeper within the codebase are just overwritten

[carstencodes]

Ah, as the smallest supported python version is 3.9, the argparse.BooleanOptionalAction is available (cf manual):

import argparse

parser = argparse.ArgumentParser()
parser.add_argument('--foo', action=argparse.BooleanOptionalAction)  # Added in version 3.9.
parser.parse_args(['--no-foo'])
Namespace(foo=False)

This should be combinable with default values.

So, a possible solution would be

sub_parser.add_argument(
            "--micro",
            action=argparse.BooleanOptionalAction,
            dest="increment_micro",
            help="When setting pre-release, specifies "
            + "whether micro version shall "
            + "be incremented as well.",
           default=True,
        )

I could give it a try, when I'm home tomorrow.

[znichollscr]

Nice. You might need to get rid of default=True too, time will tell

[carstencodes]

Unfortunately, the BooleanOptionalAction is still a bit buggy, but I managed it to setup a working implementation with a mutual exclusive argument group.

[znichollscr]

Seems to work in the quick test I did, thanks!