Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#168 Fix layout for pool settings #169

Merged
merged 1 commit into from
Nov 24, 2024
Merged

#168 Fix layout for pool settings #169

merged 1 commit into from
Nov 24, 2024

Conversation

nevendyulgerov
Copy link
Contributor

Summary

Small fix for the settings layout on the /pools/{address}/manage page.

Testing Instructions

  1. Connect your wallet.
  2. Click the link node-runners in the header.
  3. Click manage icon in a pool. PS: Create one if necessary.
  4. Scroll down to the settings area.
  5. You should be able to see the misaligned fields according to the screenshot.

@nevendyulgerov nevendyulgerov added type:bug Something isn't working and requires a fix staking Changes targeted to the Staking platform labels Nov 14, 2024
@nevendyulgerov nevendyulgerov self-assigned this Nov 14, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:39pm

@nevendyulgerov nevendyulgerov linked an issue Nov 14, 2024 that may be closed by this pull request
Pool Settings Misaligned UI #168
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11837127826

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.511%
Totals Coverage Status
Change from base Build 11450391697: 0.0%
Covered Lines: 338
Relevant Lines: 401
💛 - Coveralls

@brunomenezes brunomenezes merged commit 2446649 into main Nov 24, 2024
6 of 7 checks passed
@brunomenezes brunomenezes deleted the bugfix/168-fix-layout-issues branch November 24, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

Assignees

@nevendyulgerov nevendyulgerov

Labels
staking Changes targeted to the Staking platform type:bug Something isn't working and requires a fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pool Settings Misaligned UI
3 participants
@nevendyulgerov @coveralls @brunomenezes