New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add log_step and verify_step #297

Merged

edubart merged 1 commit into main from feature/log-step-b

Dec 20, 2024

Collaborator

mpernambuco commented Dec 17, 2024 •

edited

Loading

This branch adds the ability to record and verify a step log file of a given number of mcycles.
New API methods:

log_step(mcycle_count, filename)
verify_step(hash_before, filename, mcycle_count, hash_after)

CLI

$ cartesi-machine  --max-mcycle=0 --log-step=10,/tmp/step2.bin 
Logging step of 10 cycles to /tmp/step2.bin
0: 6eb4c70488042d71abb54b7be683385359474f7adc50a4cc4dc12d62ae182491
10: 07d65b0492a159005829b9feb17a26be1623b9124fa5c478c828fd038cff6c36

mpernambuco force-pushed the feature/log-step-b branch 5 times, most recently from 1a75c06 to 9b8e9fc Compare

December 17, 2024 14:51

edubart requested review from edubart and diegonehab

December 17, 2024 15:09

edubart assigned mpernambuco

edubart added the enhancement label

edubart added this to the v0.19.0 milestone

diegonehab reviewed

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

edubart requested changes

View reviewed changes

src/machine-merkle-tree.cpp Outdated Show resolved Hide resolved

src/replay-step-state-access.h Outdated Show resolved Hide resolved

src/machine-c-api.h Show resolved Hide resolved

src/cartesi-machine.lua Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/cartesi-machine.lua Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/clua-i-virtual-machine.cpp Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/jsonrpc-discover.json Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/machine-c-api.cpp Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/machine-c-api.h Show resolved Hide resolved

edubart requested changes

View reviewed changes

src/cartesi-machine.lua Outdated Show resolved Hide resolved

src/machine-c-api.h Outdated Show resolved Hide resolved

tests/lua/machine-bind.lua Outdated Show resolved Hide resolved

tests/lua/machine-bind.lua Outdated Show resolved Hide resolved

src/machine-c-api.cpp Show resolved Hide resolved

src/machine-merkle-tree.cpp Outdated Show resolved Hide resolved

src/replay-step-state-access-interop.cpp Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/record-step-state-access.h Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/record-step-state-access.h Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/replay-step-state-access.h Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

src/replay-step-state-access.h Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

tests/lua/cartesi-machine-tests.lua Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

tests/lua/machine-bind.lua Outdated Show resolved Hide resolved

diegonehab reviewed

View reviewed changes

tests/lua/machine-bind.lua Outdated Show resolved Hide resolved

diegonehab requested changes

View reviewed changes

Contributor

diegonehab left a comment

See comments.

edubart reviewed

View reviewed changes

tests/lua/cartesi-machine-tests.lua Outdated Show resolved Hide resolved

src/machine.cpp Outdated Show resolved Hide resolved

mpernambuco force-pushed the feature/log-step-b branch 3 times, most recently from bae6a46 to 80e8942 Compare

December 18, 2024 13:52

mpernambuco force-pushed the feature/log-step-b branch 4 times, most recently from 7920f80 to af965ed Compare

December 19, 2024 12:17


          feat!: add log_step and verify_step

b4a2907

mpernambuco force-pushed the feature/log-step-b branch from af965ed to b4a2907 Compare

December 19, 2024 14:09

mpernambuco requested review from diegonehab and edubart

December 19, 2024 14:53

edubart approved these changes

View reviewed changes

diegonehab approved these changes

View reviewed changes

edubart merged commit b4a2907 into main

8 checks passed

edubart deleted the feature/log-step-b branch

December 20, 2024 16:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels