Closed
Conversation
mpernambuco
force-pushed
the
configure-hash-algo
branch
from
2ce5def to
7f5a4a8
Compare
mpernambuco
force-pushed
the
configure-hash-algo
branch
from
7f5a4a8 to
0aa319c
Compare
Collaborator
|
I am closing this because this some portions of it was adopted and adjusted to support vectorized SHA-256 hashing in #335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new machine configuration setting -
hash_tree_target.It determines if the hash tree will be used by the uarch or RISC Zero environments.
The hashing algorithm changes depending on the
hash_tree_target; uarch uses Keccak, RISC Zero uses SHA-256.The scoped/templated hash_types have been replaced by machine_hash; always 32 bytes long.
i_hasher is no longer a CRTP interface. It is now a class that can do either Keccak or SHA-256. The name is still i_hash to make it easier to do rename and merge with the upcoming hash tree simplification/optimization.