-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all Lua tests using a Lua testing framework #37
Draft
edubart
wants to merge
12
commits into
main
Choose a base branch
from
feature/new-lua-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edubart
changed the title
Feature/new lua tests
Refactor all Lua tests using a Lua testing framework
May 19, 2023
edubart
added
the
refactor
Restructuring code, while not changing its original functionality
label
May 24, 2023
edubart
force-pushed
the
feature/new-lua-tests
branch
from
May 31, 2023 17:04
ba6d769
to
431a39c
Compare
edubart
force-pushed
the
feature/new-lua-tests
branch
2 times, most recently
from
June 6, 2023 15:40
e4326fb
to
5e06748
Compare
edubart
force-pushed
the
feature/new-lua-tests
branch
from
June 6, 2023 18:40
5e06748
to
db3ffd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
refactor
Restructuring code, while not changing its original functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP.
This PR contains the following
This is how the new Lua testing framework looks like:
This PR depends on
This PR depends on the above PRs, they should be reviewed first.