Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing mkdir in make install-mock #58

Merged
merged 1 commit into from
May 9, 2024
Merged

Missing mkdir in make install-mock #58

merged 1 commit into from
May 9, 2024

Conversation

tuler
Copy link
Member

@tuler tuler commented May 9, 2024 

make install-mock PREFIX=$PWD/_install

fails because of missing mkdir of header files.

@tuler tuler requested a review from mpolitzer May 9, 2024 04:35
@tuler tuler force-pushed the fix/install-mock branch from 8f3c521 to 2265017 Compare May 9, 2024 04:37
mpolitzer
mpolitzer approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@mpolitzer mpolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuler tuler merged commit 15d8d7a into main May 9, 2024
3 checks passed
@tuler tuler deleted the fix/install-mock branch May 9, 2024 04:50
@vfusco vfusco added this to the v0.16.0 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpolitzer mpolitzer mpolitzer approved these changes

Assignees

@tuler tuler

Labels
None yet
Projects
Machine Emulator SDK
Status: Done
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tuler @mpolitzer @vfusco