Merged
Conversation
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
4 times, most recently
from
846e96b to
e69cc46
Compare
mpolitzer
force-pushed
the
feat/prevrandao
branch
from
5a82a6e to
2a52a99
Compare
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
2 times, most recently
from
4bbc83c to
0cf1185
Compare
mpolitzer
force-pushed
the
feat/prevrandao
branch
from
2a52a99 to
4655901
Compare
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
from
0cf1185 to
0ab23c3
Compare
mpolitzer
force-pushed
the
feat/prevrandao
branch
2 times, most recently
from
be43b46 to
c15877d
Compare
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
from
0ab23c3 to
c8b080b
Compare
edubart
approved these changes
Jun 3, 2024
edubart
previously approved these changes
Jun 3, 2024
mpolitzer
force-pushed
the
feat/prevrandao
branch
from
c15877d to
194a7df
Compare
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
2 times, most recently
from
bc9a124 to
de3ba4d
Compare
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
5 times, most recently
from
a4bf19d to
4c574fa
Compare
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
5 times, most recently
from
0787ba3 to
c8a4706
Compare
diegonehab
reviewed
Jun 21, 2024
| ARG_VERSION=${VERSION} \ | ||
| TARGET_PREFIX=/usr \ | ||
| TARGET_DESTDIR=${BUILD_BASE}/install/run \ | ||
| install-run libcmt-v${VERSION}.deb |
Contributor
There was a problem hiding this comment.
Is the convention to have the "v" in the version? Same for the others.
Contributor
Author
There was a problem hiding this comment.
That is what we do in machine-emulator, e.g. https://github.com/cartesi/machine-emulator/releases/download/v0.18.0-test1/cartesi-machine-v0.17.0_amd64.deb
diegonehab
reviewed
Jun 21, 2024
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
from
c8a4706 to
8e449c6
Compare
edubart
requested changes
Jun 21, 2024
edubart
requested changes
Jun 21, 2024
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
from
8e449c6 to
a27b825
Compare
mpolitzer
force-pushed
the
feat/libcmt-split-packages
branch
from
a27b825 to
4e27e55
Compare
edubart
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build and release separate
-runand-devpackages.close #59