-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/packaging #88
base: main
Are you sure you want to change the base?
Conversation
4602034
to
2adc6fb
Compare
393810d
to
b24987f
Compare
b24987f
to
f3933bf
Compare
8999ca7
to
b245556
Compare
b245556
to
37b1e25
Compare
33f5e0a
to
9518d03
Compare
9518d03
to
37318e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen that you are also working on the machine-rootfs-image
repo. Just confirming, the idea is to remove the fs/*
from here on a later commit right?
@@ -1,22 +1,24 @@ | |||
# Final image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should disable this warning[1] by adding this to the top[2] of this file.
[1]
1 warning found (use docker --debug to expand):
- FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/riscv64" (line 2)
[2]
# syntax=docker/dockerfile:1
# check=skip=FromPlatformFlagConstDisallowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, will do on upcoming changes after we decide what to do with tools rootfs image.
--output type=tar,dest=rootfs.tar \ | ||
--file fs/Dockerfile \ | ||
. && \ | ||
xgenext2fs -fzB 4096 -b 25600 -i 4096 -a rootfs.tar -L rootfs $(TOOLS_ROOTFS) && \ | ||
xgenext2fs -fzB 4096 -i 4096 -r +4096 -a rootfs.tar -L rootfs $(TOOLS_ROOTFS) && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really remember why but someone asked for this image to be a fixed size.
@vfusco do you remember this detail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed because when updating to Ubuntu 24.04 I got some very strange errors, took me a while to understand that the size was not big enough.
But this image is going to be removed, or used only for CI testing, so I don't see a problem on the change, packages won't use this image.
Although it won't be used to packages, we have to decide if we keep tools rootfs image so we can test new tools release in our CI more easily, if so maybe then rename to rootfs-tools-test.ext2
.
1508484
to
ebff128
Compare
My recent changes just fixed the install path of |
This add a bunch of changes to make packaging of tools easier from inside a riscv64 environment (no cross compilation), while also allowing to cross compile when not inside a riscv64 environment.
The PR simplifies a lot the build scripts, by removing all Debian packaging. It also bump tools version (preparing for next release). For all the changes read the changelog.