Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/packaging #88

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Feature/packaging #88

wants to merge 13 commits into from

Conversation

edubart
Copy link
Contributor

@edubart edubart commented Jan 14, 2025

This add a bunch of changes to make packaging of tools easier from inside a riscv64 environment (no cross compilation), while also allowing to cross compile when not inside a riscv64 environment.

The PR simplifies a lot the build scripts, by removing all Debian packaging. It also bump tools version (preparing for next release). For all the changes read the changelog.

@edubart edubart self-assigned this Jan 14, 2025
@edubart edubart added the enhancement New feature or request label Jan 14, 2025
@edubart edubart linked an issue Jan 14, 2025 that may be closed by this pull request
10 tasks
@edubart edubart added this to the v0.17.0 milestone Jan 14, 2025
This was referenced Jan 14, 2025
@edubart edubart force-pushed the feature/packaging branch 2 times, most recently from 393810d to b24987f Compare January 15, 2025 16:34
@edubart edubart force-pushed the feature/packaging branch 9 times, most recently from 8999ca7 to b245556 Compare January 16, 2025 12:03
@edubart edubart requested a review from mpolitzer January 16, 2025 16:20
@edubart edubart marked this pull request as ready for review January 16, 2025 16:26
@edubart edubart linked an issue Jan 16, 2025 that may be closed by this pull request
mpolitzer
mpolitzer previously approved these changes Jan 17, 2025
Copy link
Collaborator

@mpolitzer mpolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen that you are also working on the machine-rootfs-image repo. Just confirming, the idea is to remove the fs/* from here on a later commit right?

@@ -1,22 +1,24 @@
# Final image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should disable this warning[1] by adding this to the top[2] of this file.

[1]

 1 warning found (use docker --debug to expand):                                                                                                                                               
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/riscv64" (line 2)                                                                                

[2]

# syntax=docker/dockerfile:1
# check=skip=FromPlatformFlagConstDisallowed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, will do on upcoming changes after we decide what to do with tools rootfs image.

--output type=tar,dest=rootfs.tar \
--file fs/Dockerfile \
. && \
xgenext2fs -fzB 4096 -b 25600 -i 4096 -a rootfs.tar -L rootfs $(TOOLS_ROOTFS) && \
xgenext2fs -fzB 4096 -i 4096 -r +4096 -a rootfs.tar -L rootfs $(TOOLS_ROOTFS) && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really remember why but someone asked for this image to be a fixed size.
@vfusco do you remember this detail?

Copy link
Contributor Author

@edubart edubart Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed because when updating to Ubuntu 24.04 I got some very strange errors, took me a while to understand that the size was not big enough.

But this image is going to be removed, or used only for CI testing, so I don't see a problem on the change, packages won't use this image.

Although it won't be used to packages, we have to decide if we keep tools rootfs image so we can test new tools release in our CI more easily, if so maybe then rename to rootfs-tools-test.ext2.

@edubart edubart requested a review from mpolitzer January 23, 2025 15:45
@edubart
Copy link
Contributor Author

edubart commented Jan 23, 2025

My recent changes just fixed the install path of rollup-init and xhalt, which were preventing emulator tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Waiting Merge
Development

Successfully merging this pull request may close these issues.

Packaging issues Bump guest rootfs to Ubuntu 24.04
2 participants