Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support rollups v2 #269

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Feat: Support rollups v2 #269

wants to merge 29 commits into from

Conversation

brunomenezes
Copy link
Collaborator

@brunomenezes brunomenezes commented Nov 27, 2024 •
edited
Loading

Summary

Code changes to support both v1 and v2 rollup cartesi applications.

I suggest the reviewer look commit by commit as each is related to blocks of changes that make sense and are smaller rather than the Files changed as they're loose and it is just too much cognitive power. My two cents as a reviewer myself.

Summary of changes:

  • Added new rollups-v2 contracts for wagmi code generation.
  • Added new graphQL schema, queries and codegen for v2.
  • Added new system Specification for the new v2 contracts (e.g. EtherPortal, ERC20Portal, etc)
  • Update method resolver and how to check the input row status for v2 applications.
  • Update page navigation now, including the version in the URL. Also, handle cases where the version is not in the URL.
  • Added voucher execution support for v2 apps.
  • Added Rollup v2 Output ABI to support decoding the voucher's payload from an Application v2. It has a different structure.
  • Upgrade Send transaction functionality :
    • Update EtherPortal deposit to support v1 and v2 apps.
    • Update ERC20Portal deposit to support v1 and v2 apps.
    • Update ERC721Portal deposit to support v1 and v2 apps.
    • Update ERC1155 single and batch portal deposit to support v1 and v2 apps.
    • Update Generic Input form (a.k.a InputBox add input) form to support v1 and v2 apps.
    • Update the DAppAddress relay form to support only v1 apps. The search will always be filtered by v1.
  • Changed how to get human readable method and name for addresses that are related to Rollup Contracts e.g. EtherPortal and method etherDeposit that are displayed in the list of inputs.
  • Refactored a search e2e test case to improve resilience bb24888. It was also breaking check the link below
  • Skipped the remaining e2e tests that interact with Metamask (Last main build is actually not passing action here) It gets stuck in the CI environment.

To check the navigation without the version for the edge case of the same address, different versions
you can use the following application address on Sepolia.

0xab7528bb862fb57e8a2bcd567a2e929a0be56a5e

PS: I will leave the NEXT_PUBLIC_PREVIEW_EXPLORER_API_URL environment variable around as part of the deployment strategy. Later, a PR may come and remove that guy.

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-arbitrum-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm
rollups-explorer-arbitrum-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm
rollups-explorer-base-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm
rollups-explorer-base-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm
rollups-explorer-optimism-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm
rollups-explorer-optimism-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:18pm

@brunomenezes brunomenezes force-pushed the feat/rollups-v2-support branch from 1143e72 to 658a6fd Compare November 28, 2024 05:32
@brunomenezes brunomenezes force-pushed the feat/rollups-v2-support branch from 68cbb5c to a817ebf Compare November 28, 2024 23:47
@brunomenezes brunomenezes force-pushed the feat/rollups-v2-support branch from a817ebf to ba817a7 Compare November 29, 2024 22:23
@nevendyulgerov nevendyulgerov self-requested a review December 13, 2024 10:49
nevendyulgerov
nevendyulgerov previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@nevendyulgerov nevendyulgerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retested after the latest changes using https://rollups-explorer-sepolia-git-feat-rollups-v2-support-cartesi.vercel.app. Everything looks good, @brunomenezes !

@brunomenezes
Copy link
Collaborator Author

Let's hold up a bit the merge.

@brunomenezes brunomenezes added Status: On-Hold On-hold for further development, because upcoming changes will affect the Issue or PR targeted apps: web labels Dec 15, 2024
@brunomenezes
feat: Add local explorer schema for codegen. Remove all references to…
69bd2d8 
… the PREVIEW_API env var. Fix a few lines on dockerfile based on docker warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevendyulgerov nevendyulgerov nevendyulgerov left review comments

@tuler tuler Awaiting requested review from tuler

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
apps: web Status: On-Hold On-hold for further development, because upcoming changes will affect the Issue or PR targeted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunomenezes @nevendyulgerov