Feat: Ether deposit validation on change and display balance #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactoring on how ether-form is exported.
… a new test helper for transaction success lifecycle.
7 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brunomenezes
changed the title
| @@ -54,22 +56,27 @@ export const EtherDepositForm: FC<EtherDepositFormProps> = (props) => { | |||
| } = props; | |||
| const [advanced, { toggle: toggleAdvanced }] = useDisclosure(false); | |||
| const { chain } = useAccount(); | |||
| const balance = useFormattedBalance(); | |||
There was a problem hiding this comment.
It seems that we won't be needing useFormattedBalance hook. If this is true, please delete it and the related unit test suite.
There was a problem hiding this comment.
Removed on c9c0c7f
| <Flex c={"dark.2"} gap="3"> | ||
| <Text fz="xs">Balance: {accountBalance.formatted}</Text> | ||
| {accountBalance.value > 0 && ( | ||
| <UnstyledButton |
There was a problem hiding this comment.
Can we switch to using the standard Button component instead?
There was a problem hiding this comment.
Hey! I started with the <Button>, but I needed to unstyle it (no pun intended) to reach the same result, i.e. adding variant: transparent, height: auto and padding 0 besides the required one for the inner text. Hence, the reason to use the <UnstyledButton />.
nevendyulgerov
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code changes to improve feedback in the ether deposit form. Also, I refactored the test file for the ether-deposit form before adding the new test cases (separated commits).
Changes:
maxbutton is available to click.