feat(aws): Add GuardDutyDetector to AWS module #1765
+357
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
1 issue found across 6 files • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
priyanshuharshbodhi1
force-pushed
the
Feat-add-guardduty-to-AWS
branch
3 times, most recently
from
4bb553d to
11937a4
Compare
d-aggarwal
requested changes
Aug 4, 2025
|
@d-aggarwal @achantavy , PTAL! I have made some updates. |
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
- Remove try/except block from get_detector_details (decorator handles exceptions) - Move ARN construction logic from load to transform function - Update transform_detector_details to accept aws_account_id parameter - Remove separate detectors.json file as suggested - Update tests to work with new function signatures Signed-off-by: Priyanshu Harshbodhi <[email protected]>
priyanshuharshbodhi1
force-pushed
the
Feat-add-guardduty-to-AWS
branch
from
24ac22f to
9840942
Compare
achantavy
approved these changes
Aug 5, 2025
Comment on lines
+330
to
+340
| detector_details = get_detector_details(boto3_session, region, detector_ids) | ||
| transformed_detectors = transform_detector_details( | ||
| detector_details, region, current_aws_account_id | ||
| ) | ||
| load_guardduty_detectors( | ||
| neo4j_session, | ||
| transformed_detectors, | ||
| region, | ||
| current_aws_account_id, | ||
| update_tag, | ||
| ) |
There was a problem hiding this comment.
Let's move this out to a sync_detectors_function() and then call it from within sync().
achantavy
requested changes
Aug 5, 2025
- Extract sync_detectors_function() - Add comprehensive integration tests - All tests passing for both unit and integration coverage Signed-off-by: Priyanshu Harshbodhi <[email protected]>
Signed-off-by: Priyanshu Harshbodhi <[email protected]>
jychp
changed the title
achantavy
requested changes
Aug 13, 2025
Comment on lines
+218
to
+227
| # Test outcomes - verify ARN construction is correct | ||
| detectors = neo4j_session.run( | ||
| "MATCH (d:GuardDutyDetector) RETURN d.detector_id as detector_id, d.arn as arn" | ||
| ).data() | ||
|
|
||
| for detector in detectors: | ||
| expected_arn = f"arn:aws:guardduty:{TEST_REGION}:{TEST_ACCOUNT_ID}:detector/{detector['detector_id']}" | ||
| assert ( | ||
| detector["arn"] == expected_arn | ||
| ), f"ARN mismatch for detector {detector['detector_id']}" |
There was a problem hiding this comment.
Remove this test. It's overly verbose and doesn't use the check_nodes() pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds GuardDuty Detector support to AWS modules
Related issues or links
(#1477)
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:
If you are changing a node or relationship:
If you are implementing a new intel module: