test(gcp): Add synchronization tests for GCP DNS and CRM Integration #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ography-cncf#1742) ### Summary > Describe your changes. - Added a check in each event types transform function that skips the event if the requestParameters field of the API data is null - Added unit tests for null requestParameters case ### Related issues or links > Include links to relevant issues or other pages. - cartography-cncf#1740 --------- Signed-off-by: shyammukund <[email protected]> Co-authored-by: Kunaal Sikka <[email protected]> Signed-off-by: wahidullah <[email protected]>
Signed-off-by: wahidullah <[email protected]>
wahid18-maqs
force-pushed
the
test-integration-gcp-crm-dns
branch
from
ddfe416 to
b36cdd3
Compare
wahid18-maqs
changed the title
|
Hi @achantavy sir,I've added sync tests for CRM and DNS in the GCP integration. |
jychp
changed the title
jychp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added tests for CRM and DNS sync. All tests are passing.
Related issues or links
Screenshot
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:
If you are changing a node or relationship:
If you are implementing a new intel module: