Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to the new Github Org #698

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

joaopapereira
Copy link
Member

No description provided.

@joaopapereira joaopapereira marked this pull request as ready for review October 20, 2023 15:54
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for carvel ready!

Name Link
🔨 Latest commit 17ec2fb
🔍 Latest deploy log https://app.netlify.com/sites/carvel/deploys/653a9aafdcc4f8000868e74f
😎 Deploy Preview https://deploy-preview-698--carvel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might take a while to review the complete PR, I have reviewed a small part of it (all the sections except for docs). I have added all the comments as suggestions in case you don't want to go back to each file and make those changes.

GOVERNANCE.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
proposals/ytt/002-raw-data-values/README.md Outdated Show resolved Hide resolved
site/content/blog/imgpkg-tags.md Outdated Show resolved Hide resolved
Signed-off-by: Joao Pereira <[email protected]>
@joaopapereira joaopapereira force-pushed the remove-references-to-vmware-tanzu-org branch from bdb8d33 to 3ff2594 Compare October 23, 2023 19:58
@microwavables
Copy link
Contributor

microwavables commented Oct 23, 2023

I reviewed most of it and the blog footer, assuming that's the crux of what you needed me to approve but let me know if you need further review from me!
I forgot to look at the deploy preview and the footer of blog post is not working / showing. I just see {{ partial “_blog_footer” . }}

@joaopapereira joaopapereira force-pushed the remove-references-to-vmware-tanzu-org branch from 3ff2594 to 6dfdeca Compare October 23, 2023 21:44
@microwavables
Copy link
Contributor

LGTM

@@ -4,7 +4,7 @@ title: OSS Carvel Packages

This page provides a list of Carvel Packages and Package Repositories that are available to open source users.

Do you have a Package or Package Repository you'd like to add to this list? Please make a PR with details to our [docs](https://github.com/vmware-tanzu/carvel/main/site/content/kapp-controller/docs/latest/oss-packages.md).
Do you have a Package or Package Repository you'd like to add to this list? Please make a PR with details to our [docs](https://github.com/carvel-dev/carvelmain/site/content/kapp-controller/docs/latest/oss-packages.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't work even now, and this page probably needs to be updated, so I am okay if we want to ignore this for a while.

Suggested change
Do you have a Package or Package Repository you'd like to add to this list? Please make a PR with details to our [docs](https://github.com/carvel-dev/carvelmain/site/content/kapp-controller/docs/latest/oss-packages.md).
Do you have a Package or Package Repository you'd like to add to this list? Please make a PR with details to our [docs](https://github.com/carvel-dev/carvel/blob/develop/site/content/kapp-controller/docs/develop/oss-packages.md).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same for other versions of kapp-controller)


### Issues, Branching, Pull Requests, Approval
* Issues (see also, [issue triaging docs](hhttps://github.com/carvel-dev/carvel/blob/develop/processes/issue-triage.md) for more info!)
* [Proposal Process](https://github.com/vmware-tanzu/carvel/tree/develop/proposals#carvel-proposals)
* [Proposal Process](https://github.com/carvel-dev/carveltree/develop/proposals#carvel-proposals)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Proposal Process](https://github.com/carvel-dev/carveltree/develop/proposals#carvel-proposals)
* [Proposal Process](https://github.com/carvel-dev/carvel/tree/develop/proposals#carvel-proposals)

* Prefer to leave issues open until documentation is complete
* Docs typically live in a [separate
repo](https://github.com/vmware-tanzu/carvel/tree/develop/site) which
repo](https://github.com/carvel-dev/carveltree/develop/site) which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo](https://github.com/carvel-dev/carveltree/develop/site) which
repo](https://github.com/carvel-dev/carvel/tree/develop/site) which

<p>We look forward to hearing from you and hope you join us in building a strong packaging and distribution story
for
applications on Kubernetes!</p>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline at the end of file

Signed-off-by: Joao Pereira <[email protected]>
@joaopapereira joaopapereira merged commit 9202ffe into develop Oct 26, 2023
8 checks passed
@joaopapereira joaopapereira deleted the remove-references-to-vmware-tanzu-org branch October 26, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants