Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention --default-label-scoping-rules CLI option #775

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ringerc
Copy link
Contributor

@ringerc ringerc commented Aug 12, 2024

Mention the --default-label-scoping-rules=false CLI option, add a FAQ section about kapp's labels, and cross-link the docs in the apply section with the configuration.

I found kapp's use of labels rather than annotations quite confusing and frustrating when I hit this bug that breaks kube-prometheus's service label selector. Hopefully this will save someone else some time.

May require merge with #773

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for carvel canceled.

Name Link
🔨 Latest commit d10c555
🔍 Latest deploy log https://app.netlify.com/sites/carvel/deploys/66b994b879b4830008e2e56d

Mention the --default-label-scoping-rules=false CLI option,
add a FAQ section about kapp's labels, and cross-link the
docs in the apply section with the configuration.

Signed-off-by: Craig Ringer <[email protected]>
@praveenrewar
Copy link
Member

Thank you for making the docs better @ringerc!
Do you also want to make the change in older versions of kapp? Or at least the latest version along with develop.

@ringerc
Copy link
Contributor Author

ringerc commented Sep 5, 2024

Yes, I can backport to latest stable. Will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants