Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance custom waiting behavior. #983

Closed
rohitagg2020 opened this issue Jul 10, 2024 · 0 comments · Fixed by #994
Closed

Enhance custom waiting behavior. #983

rohitagg2020 opened this issue Jul 10, 2024 · 0 comments · Fixed by #994
Assignees
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@rohitagg2020
Copy link
Contributor

Describe the problem/challenge you have
There are certain scenarios where a custom resource moves to the FAILED state before coming to the SUCCESSFUL state. e.g. if a resource has external dependency as part of its readiness criteria, and this external dependency itself takes time to come, then resource moves to FAILED state and kapp deploy exits with error. But once the external service comes up, custom resource readiness criteria is fulfilled and it moves to the SUCCESSFUL state.

Describe the solution you'd like
I would like kapp deploy to not fail aggressively and rather it should fail only if the app has been in FAILED state for lets say 5 min.

Anything else you would like to add:
[Additional information that will assist in solving the issue.]


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@rohitagg2020 rohitagg2020 added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity labels Jul 10, 2024
@renuy renuy added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Jul 10, 2024
@rohitagg2020 rohitagg2020 self-assigned this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants