983: Adding timeout in waitRules

[rohitagg2020]

Sample Output

$ kapp deploy -a simpleapp -f ~/config/pod-config.yml
Target cluster 'https://127.0.0.1:58277' (nodes: kind-control-plane)

Changes

Namespace  Name   Kind  Age  Op      Op st.  Wait to    Rs  Ri
default    nginx  Pod   -    create  -       reconcile  -   -

Op:      1 create, 0 delete, 0 update, 0 noop, 0 exists
Wait to: 1 reconcile, 0 delete, 0 noop

Continue? [yN]: y

11:08:45AM: ---- applying 1 changes [0/1 done] ----
11:08:46AM: create pod/nginx (v1) namespace: default
11:08:46AM: ---- waiting on 1 changes [0/1 done] ----
11:08:46AM: ongoing: reconcile pod/nginx (v1) namespace: default
11:08:46AM:  ^ ContainersReady: ContainersNotReady (message: containers with unready status: [nginx])
11:09:16AM: fail: reconcile pod/nginx (v1) namespace: default
11:09:16AM:  ^ Encountered failure condition ContainersReady == False: ContainersNotReady (message: containers with unready status: [nginx]) continuously for 30s duration

kapp: Error: waiting on reconcile pod/nginx (v1) namespace: default:
  Finished unsuccessfully (Encountered failure condition ContainersReady == False: ContainersNotReady (message: containers with unready status: [nginx]) continuously for 30s duration)

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

Fixes #983

Additional Notes for your reviewer:

Review Checklist:

• Follows the developer guidelines
• Relevant tests are added or updated
• Relevant docs in this repo added or updated
• Relevant carvel.dev docs added or updated in a separate PR and there's
  a link to that PR
• Code is at least as readable and maintainable as it was before this
  change

Additional documentation e.g., Proposal, usage docs, etc.:

[praveenrewar]

LGTM!

[100mik]

We do need to document this behaviour