Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip API operations for diff run #793

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Skip API operations for diff run #793

merged 1 commit into from
Aug 8, 2023

Commits on Aug 7, 2023

  1. Skip API operations for diff run

    Diff run should be usable when the authorised RBAC role doesn't have
    write permissions for resources in the cluster.
    
    Diff run on app creation used the dry run feature of the Kubernetes
    API, to avoid persisting kapp ConfigMap changes. However this still
    checks RBAC permissions, and errored if the role did not have write
    permissions for ConfigMaps.
    
    The kapp ConfigMap was also being updated when doing a diff run for an
    existing app.
    
    This skips the API operations for updating the ConfigMap when doing a
    diff run.
    
    Fixes #791.
    
    Signed-off-by: Anshul Sirur <[email protected]>
    vixus0 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    28cbd94 View commit details
    Browse the repository at this point in the history