Add --app-namespace flag #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100mik
reviewed
Sep 4, 2023
praveenrewar
force-pushed
the
app-namespace
branch
from
73a5fe7
to
e671c8a
Compare
100mik
reviewed
Sep 14, 2023
Signed-off-by: Praveen Rewar <[email protected]>
praveenrewar
force-pushed
the
app-namespace
branch
from
e671c8a
to
511167d
Compare
|
Looks like the tests are not happy, not sure if it is a flake 🤔 |
rcmadhankumar
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: Praveen Rewar <[email protected]>
rcmadhankumar
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: Praveen Rewar <[email protected]>
jfmontanaro
added a commit
to jfmontanaro/carvel
that referenced
this pull request
Mar 5, 2024
…space.md When using a dedicated namespace for state storage, the docs currently suggest specifying this namespace via the `-n` flag. However this can lead to undesirable behaviors, since the app is typically being deployed to a different namespace. In my case, I had a resource where I had neglected to specify the namespace, and it would have ended up getting deployed to the state-storage namespace rather than the same namespace as the rest of the app. This was discussed in carvel-dev/kapp#815 and fixed in carvel-dev/kapp#814 with the introduction of the `--app-namespace` flag, which controls which is used for state storage independently of the app namespace. However the docs did not reflect this change. This commit adjusts the documentation to recommend using `--app-namespace` when storing configs in a separate namespace.
jfmontanaro
added a commit
to jfmontanaro/carvel
that referenced
this pull request
Mar 12, 2024
…space.md When using a dedicated namespace for state storage, the docs currently suggest specifying this namespace via the flag. However this can lead to undesirable behaviors, since the app is typically being deployed to a different namespace. In my case, I had a resource where I had neglected to specify the namespace, and it would have ended up getting deployed to the state-storage namespace rather than the same namespace as the rest of the app. This was discussed in carvel-dev/kapp#815 and fixed in carvel-dev/kapp#814 with the introduction of the flag, which controls which is used for state storage independently of the app namespace. However the docs did not reflect this change. This commit adjusts the documentation to recommend using when storing configs in a separate namespace. Signed-off-by: Joseph Montanaro <[email protected]>
100mik
pushed a commit
to carvel-dev/carvel
that referenced
this pull request
Mar 17, 2024
…space.md When using a dedicated namespace for state storage, the docs currently suggest specifying this namespace via the flag. However this can lead to undesirable behaviors, since the app is typically being deployed to a different namespace. In my case, I had a resource where I had neglected to specify the namespace, and it would have ended up getting deployed to the state-storage namespace rather than the same namespace as the rest of the app. This was discussed in carvel-dev/kapp#815 and fixed in carvel-dev/kapp#814 with the introduction of the flag, which controls which is used for state storage independently of the app namespace. However the docs did not reflect this change. This commit adjusts the documentation to recommend using when storing configs in a separate namespace. Signed-off-by: Joseph Montanaro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add
--app-namespaceflag to kapp deploy, inspect and delete commands. This can be used to specify the namespace to store kapp meta configmaps.Which issue(s) this PR fixes:
Fixes #815
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: