Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on specifying a .env path with a string #1640

Closed
wants to merge 5 commits into from

Conversation

groovenectar
Copy link

As someone not well-versed in Rust yet, only a fan, this update in this project turns out to be non-trivial

But I did update some README files, so I'd like to draft a pull request as I've been pondering this feature for quite some time

I plan to revisit this, but would definitely appreciate any help or pointers

This addresses some posted issues such as #945

Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! just is definitely non-trivial to work on, there are a lot of layers (lexer, parser, error handling, documentation, etc) to modify.

I think it would probably be better to add a new setting, dotenv-path, which takes a string.

As far as pointers, check out the tempdir setting, since takes a string, and dotenv-path will probably have a similar implementation.

@casey
Copy link
Owner

casey commented Oct 12, 2023

This wound up being implemented in #1692.

@casey casey closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants