feat: add semver_matches utility function#1713
Merged
casey merged 4 commits intocasey:masterfrom Oct 27, 2023
t3hmrman:feat/add-semver-match-utility
Merged
feat: add semver_matches utility function#1713casey merged 4 commits intocasey:masterfrom t3hmrman:feat/add-semver-match-utility
semver_matches utility function#1713casey merged 4 commits intocasey:masterfrom
t3hmrman:feat/add-semver-match-utility
Conversation
Contributor
Author
|
Hey @casey got some code up to implement the new utility -- please let me know if I'm missing anything, or if you'd like more test cases! |
casey
approved these changes
Oct 27, 2023
Owner
casey
left a comment
casey
left a comment
There was a problem hiding this comment.
Looks good! Check out the review comments.
Contributor
Author
|
Thanks for the thorough review @casey , I made the changes and squashed to get one commit (I'm a fan of single non-merge commit history). |
While coordinating different programs using `just`, it's often necessary to compare the *versions* of different binaries or utilitiies. Assuming that the utility in question providers a `--version` switch and can reasonably print out a version, being able to match semver of the utility to an expectation is very useful. This commit adds a `semver_matches` utility which utilizes the `semver` crate (https://crates.io/crates/semver) to provide matching functionality to `Justfile`s. Signed-off-by: vados <vados@vadosware.io> Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Owner
|
Nice, merged! Thank you for the PR! |
Contributor
Author
|
Thanks for the help and thorough reviews! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While coordinating different programs using
just, it's often necessary to compare the versions of different binaries or utilitiies. Assuming that the utility in question providers a--versionswitch and can reasonably print out a version, being able to match semver of the utility to an expectation is very useful.This commit adds a
semver_matchesutility which utilizes thesemvercrate (https://crates.io/crates/semver) to provide matching functionality toJustfiles.Resolves #1712