Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify aliases documentation #1726

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Clarify aliases documentation #1726

merged 2 commits into from
Nov 21, 2023

Conversation

laniakea64
Copy link
Contributor

Resolves #1725 by documenting the scope of the alternative names defined with alias. Also updated the output of the example just b command to match what current just would do.

README.md Outdated Show resolved Hide resolved
@casey
Copy link
Owner

casey commented Nov 16, 2023

Added a comment, also, the branch is out of date. You might want to set the option that allows maintainers to edit pull requests, so I can do things like update the branch.

@laniakea64
Copy link
Contributor Author

You might want to set the option that allows maintainers to edit pull requests, so I can do things like update the branch.

If that's enabled and you decide to make more significant changes than simply updating the branch, would the squash merge commit give you the co-author credit you'd deserve?

@casey
Copy link
Owner

casey commented Nov 20, 2023

If that's enabled and you decide to make more significant changes than simply updating the branch, would the squash merge commit give you the co-author credit you'd deserve?

It would, since it adds a Co-authors: Casey Rodarmor <[email protected]> line to the commit message, but I usually just delete that, since it adds noise to the commit history, and I don't mind if I don't get credit. Plus I usually only make minor changes to PRs like that.

@casey casey merged commit c6a2922 into casey:master Nov 21, 2023
5 checks passed
@casey
Copy link
Owner

casey commented Nov 21, 2023

Nice, merged!

@laniakea64 laniakea64 deleted the doc-aliases branch November 21, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying dependency by alias causes error
2 participants